Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: set cri-o systemd restart policy to no #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 26, 2020
Merged

test: set cri-o systemd restart policy to no #3483

openshift-merge-robot merged 2 commits into from
Mar 26, 2020

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Mar 26, 2020 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

While in production we want cri-o to restart when it crashes, when we're testing we'd like to catch panics and crashes. Set restart policy in the systemd unit file to never restart, so we fail tests that make cri-o panic

also drop make install.{systemd,config} when building cri-o, as the targets are already hit when running make install

I consider this a failing test because we are failing to catch when CRI-O crashes

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander
test: set cri-o systemd restart policy to no
c2ec5ae 
While in production we want cri-o to restart when it crashes, when we're testing we'd like to catch panics and crashes. Set restart policy in the systemd unit file to never restart, so we fail tests that make cri-o panic

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Mar 26, 2020
saschagrunert
saschagrunert approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@haircommander haircommander mentioned this pull request Mar 26, 2020
Merged
@haircommander
Copy link
Member Author

haircommander commented Mar 26, 2020

/retest

@codecov
Copy link

codecov bot commented Mar 26, 2020 •
edited
Loading

Codecov Report

Merging #3483 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3483   +/-   ##
=======================================
  Coverage   44.21%   44.21%           
=======================================
  Files         100      100           
  Lines        7681     7681           
=======================================
  Hits         3396     3396           
  Misses       3989     3989           
  Partials      296      296

@haircommander
Copy link
Member Author

haircommander commented Mar 26, 2020

/retest

@haircommander
test: drop make install.{systemd,config}
856ad18 
as they're redundant with make install

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
Copy link
Member Author

haircommander commented Mar 26, 2020

/retest

@haircommander
Copy link
Member Author

haircommander commented Mar 26, 2020 


TASK [install cri-o] ***********************************************************
task path: /go/src/github.com/cri-o/cri-o/contrib/test/integration/build/cri-o.yml:29
Killed by signal 15.
++ export status=FAILURE
++ status=FAILURE

???
/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Mar 26, 2020

@haircommander This is great. Fail fast in CI 👍

@mrunalp
Copy link
Member

mrunalp commented Mar 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3457c6f into cri-o:master Mar 26, 2020
@haircommander haircommander deleted the test-systemd-restart branch September 27, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @openshift-ci-robot @mrunalp @saschagrunert @openshift-merge-robot