Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.18] Bump version to v1.18.2 #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

[1.18] Bump version to v1.18.2 #3885

merged 1 commit into from
Jun 18, 2020

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 17, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

Some important fixes are part of the release branch and I guess we're ready for a new release, right?

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@saschagrunert
Bump version to v1.18.2
0497f99 
Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 17, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 17, 2020

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 17, 2020

/test launch-aws

1 similar comment
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 17, 2020

/test launch-aws

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Jun 17, 2020

LGTM and happy green test buttons.

@haircommander
Copy link
Member

haircommander commented Jun 17, 2020

LGTM, I say let's get #3851 first

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 17, 2020

LGTM, I say let's get #3851 first

Sounds good.

@dirkmueller
Copy link

dirkmueller commented Jun 18, 2020

#3851 is in now I think. Anything else we want to wait on?

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 18, 2020

#3851 is in now I think. Anything else we want to wait on?

I think we’re fine.

@haircommander should I create the release+tag (via GitHub interface) on the latest release-1.18 commit if this one got merged? 😇 the automation should work then, but we need an official “GitHub release” to be able to upload the binaries automatically.

@haircommander
Copy link
Member

haircommander commented Jun 18, 2020

#3851 is in now I think. Anything else we want to wait on?

I think we’re fine.

@haircommander should I create the release+tag (via GitHub interface) on the latest release-1.18 commit if this one got merged? innocent the automation should work then, but we need an official “GitHub release” to be able to upload the binaries automatically.

are we not able to merge this, then tag the release?

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 18, 2020

#3851 is in now I think. Anything else we want to wait on?

I think we’re fine.
@haircommander should I create the release+tag (via GitHub interface) on the latest release-1.18 commit if this one got merged? innocent the automation should work then, but we need an official “GitHub release” to be able to upload the binaries automatically.

are we not able to merge this, then tag the release?

That's what I meant. Merge this one and then tag (but via a GitHub release, not via git tag ...) :) Would this work for you?

@haircommander
Copy link
Member

haircommander commented Jun 18, 2020

#3851 is in now I think. Anything else we want to wait on?

I think we’re fine.
@haircommander should I create the release+tag (via GitHub interface) on the latest release-1.18 commit if this one got merged? innocent the automation should work then, but we need an official “GitHub release” to be able to upload the binaries automatically.

are we not able to merge this, then tag the release?

That's what I meant. Merge this one and then tag (but via a GitHub release, not via git tag ...) :) Would this work for you?

works with me, can you take care of it?
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Jun 18, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 18, 2020

/test critest_fedora

Yep.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 18, 2020

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 18, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7f261ae into cri-o:release-1.18 Jun 18, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 18, 2020

@dirkmueller I’ll cut the release. Unfortunately I’m currently on vacation so I can’t update it in OBS. feel free to submit it there and ping @rhafer or @sysrich to accept it.

@saschagrunert saschagrunert deleted the 1.18.2 branch June 18, 2020 20:41
@dirkmueller
Copy link

dirkmueller commented Jun 18, 2020

@saschagrunert did so already, thanks a lot for your help during 'vacation' ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@haircommander haircommander Awaiting requested review from haircommander

@sameo sameo Awaiting requested review from sameo

@nalind nalind Awaiting requested review from nalind

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saschagrunert @openshift-ci-robot @TomSweeneyRedHat @haircommander @dirkmueller @openshift-merge-robot