adds intermediate checking to image info #3892

wgahnagl · 2020-06-18T20:27:25Z

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

adds an intermediate flag to image info so the crictl can display --all images

Which issue(s) this PR fixes:

fixes #3149

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

prevents intermediate images from being shown in crictl, and removes them when images are deleted.

openshift-ci-robot · 2020-06-18T20:28:35Z

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-18T20:28:35Z

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-06-18T20:30:50Z

/ok-to-test

haircommander · 2020-06-18T20:31:57Z

huzzah! can you sign off the PR with git commit --amend -s and git push -f origin add-all-flag?

some tests will fail and it's not the fault of this PR

server/image_status.go

umohnani8 · 2020-06-19T14:42:07Z

/approve
Tests are going to fail till we get the cri-tools PR in and point the tests to the latest commit with the --all flag added to crictl images.

internal/storage/image.go

haircommander · 2020-06-19T19:42:09Z

/retest

internal/storage/image.go

umohnani8 · 2020-09-16T02:38:12Z

@wgahnagl the test failures look related to the PR. Tests are failing on removing images.

umohnani8 · 2020-10-12T17:42:57Z

/retest

umohnani8 · 2020-10-26T20:20:17Z

/retest

wgahnagl · 2020-10-28T17:48:33Z

/retest

…ermediate images on untag Signed-off-by: Skyler Clark <[email protected]>

openshift-merge-robot · 2020-11-18T20:31:58Z

@wgahnagl: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic	`0bf2f1b`	link	`/test e2e-agnostic`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wgahnagl · 2021-02-10T21:42:28Z

/retest

wgahnagl · 2021-02-11T14:42:21Z

/retest

wgahnagl · 2021-02-11T20:11:22Z

/retest

wgahnagl · 2021-02-15T14:35:28Z

/retest

haircommander · 2021-02-15T17:35:12Z

@wgahnagl can you rebase this?

openshift-ci · 2022-06-28T01:50:48Z

@wgahnagl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-actions · 2023-03-09T00:04:10Z

A friendly reminder that this PR had no activity for 30 days.

openshift-ci-robot · 2023-05-06T02:22:53Z

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/openshift-jenkins/critest_fedora	`7a03816`	link	`/test critest_fedora`
ci/openshift-jenkins/critest_rhel	`7a03816`	link	`/test critest_rhel`
ci/openshift-jenkins/integration_fedora	`7a03816`	link	`/test integration_fedora`
ci/openshift-jenkins/integration_crun	`7a03816`	link	`/test integration_crun`
ci/openshift-jenkins/integration_crun_cgroupv2	`7a03816`	link	`/test integration_cgroupv2`
ci/openshift-jenkins/integration_rhel	`7a03816`	link	`/test integration_rhel`
ci/kata-jenkins	`0bf2f1b`	link	true	`/test kata-containers`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2023-05-24T02:42:49Z

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic	`0bf2f1b`	link	`/test e2e-agnostic`
ci/prow/e2e-gcp	`0bf2f1b`	link	`/test e2e-gcp`
ci/prow/ci-critest	`0bf2f1b`	link	true	`/test ci-critest`
ci/prow/ci-integration	`0bf2f1b`	link	true	`/test ci-integration`
ci/prow/ci-rhel-integration	`0bf2f1b`	link	true	`/test ci-rhel-integration`
ci/prow/e2e-aws-ovn	`0bf2f1b`	link	true	`/test e2e-aws-ovn`
ci/prow/images	`0bf2f1b`	link	true	`/test images`
ci/prow/ci-images	`0bf2f1b`	link	true	`/test ci-images`
ci/prow/periodics-images	`0bf2f1b`	link	true	`/test periodics-images`
ci/prow/ci-rhel-critest	`0bf2f1b`	link	true	`/test ci-rhel-critest`
ci/prow/ci-cgroupv2-e2e	`0bf2f1b`	link	true	`/test ci-cgroupv2-e2e`
ci/prow/ci-fedora-critest	`0bf2f1b`	link	true	`/test ci-fedora-critest`
ci/prow/ci-e2e-conmonrs	`0bf2f1b`	link	true	`/test ci-e2e-conmonrs`
ci/prow/ci-rhel-e2e	`0bf2f1b`	link	true	`/test ci-rhel-e2e`
ci/prow/ci-e2e	`0bf2f1b`	link	true	`/test ci-e2e`
ci/prow/ci-cgroupv2-e2e-features	`0bf2f1b`	link	true	`/test ci-cgroupv2-e2e-features`
ci/prow/ci-cgroupv2-e2e-crun	`0bf2f1b`	link	true	`/test ci-cgroupv2-e2e-crun`
ci/prow/ci-crun-e2e	`0bf2f1b`	link	true	`/test ci-crun-e2e`
ci/prow/ci-fedora-integration	`0bf2f1b`	link	true	`/test ci-fedora-integration`
ci/prow/ci-cgroupv2-integration	`0bf2f1b`	link	true	`/test ci-cgroupv2-integration`
ci/prow/e2e-gcp-ovn	`0bf2f1b`	link	true	`/test e2e-gcp-ovn`
ci/kata-jenkins	`0bf2f1b`	link	true	`/test kata-containers`
ci/prow/ci-e2e-evented-pleg	`0bf2f1b`	link	true	`/test ci-e2e-evented-pleg`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

haircommander · 2023-05-24T16:37:53Z

it seems the attached issue was closed #3149 so I think we should close this one too

wgahnagl requested review from mrunalp and runcom as code owners June 18, 2020 20:27

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 18, 2020

openshift-ci-robot requested review from nalind and umohnani8 June 18, 2020 20:28

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2020

openshift-ci-robot requested review from rhatdan and vrothberg June 18, 2020 20:28

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2020

haircommander reviewed Jun 18, 2020

View reviewed changes

server/image_status.go Outdated Show resolved Hide resolved

wgahnagl force-pushed the add-all-flag branch 4 times, most recently from f2d7813 to 526d06b Compare June 19, 2020 14:39

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 19, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020

mrunalp reviewed Jun 19, 2020

View reviewed changes

internal/storage/image.go Outdated Show resolved Hide resolved

openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jun 22, 2020

umohnani8 reviewed Sep 16, 2020

View reviewed changes

internal/storage/image.go Show resolved Hide resolved

openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 16, 2020

wgahnagl force-pushed the add-all-flag branch from 2c2d62a to f4caacd Compare September 16, 2020 18:21

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 16, 2020

wgahnagl force-pushed the add-all-flag branch 2 times, most recently from 5e1f3ea to 7a03816 Compare September 21, 2020 17:31

openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 16, 2020

prevents imageList from returning intermediate images and deletes int…

0bf2f1b

…ermediate images on untag Signed-off-by: Skyler Clark <[email protected]>

wgahnagl force-pushed the add-all-flag branch from 7a03816 to 0bf2f1b Compare November 2, 2020 16:07

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2022

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2023

haircommander closed this May 24, 2023

adds intermediate checking to image info #3892

adds intermediate checking to image info #3892

Uh oh!

Conversation

wgahnagl commented Jun 18, 2020 • edited by haircommander Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Jun 18, 2020

Uh oh!

openshift-ci-robot commented Jun 18, 2020

Uh oh!

haircommander commented Jun 18, 2020

Uh oh!

haircommander commented Jun 18, 2020

Uh oh!

Uh oh!

umohnani8 commented Jun 19, 2020

Uh oh!

Uh oh!

haircommander commented Jun 19, 2020

Uh oh!

Uh oh!

umohnani8 commented Sep 16, 2020

Uh oh!

umohnani8 commented Oct 12, 2020

Uh oh!

umohnani8 commented Oct 26, 2020

Uh oh!

wgahnagl commented Oct 28, 2020

Uh oh!

openshift-merge-robot commented Nov 18, 2020

Uh oh!

wgahnagl commented Feb 10, 2021

Uh oh!

wgahnagl commented Feb 11, 2021

Uh oh!

wgahnagl commented Feb 11, 2021

Uh oh!

wgahnagl commented Feb 15, 2021

Uh oh!

haircommander commented Feb 15, 2021

Uh oh!

openshift-ci bot commented Jun 28, 2022

Uh oh!

github-actions bot commented Mar 9, 2023

Uh oh!

openshift-ci-robot commented May 6, 2023

Uh oh!

openshift-ci bot commented May 24, 2023

Uh oh!

haircommander commented May 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wgahnagl commented Jun 18, 2020 •

edited by haircommander

Loading