container refactor #3960

wgahnagl · 2020-07-16T18:19:59Z

What type of PR is this?

/kind api-change
/kind bug

/kind cleanup

/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Begins cleaning up the container create functions, and moves the spec generation into container where it can be vendored and reused, and also is easier to test.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

openshift-ci-robot · 2020-07-16T18:21:41Z

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

server/container_create_linux.go

haircommander · 2020-07-16T20:09:00Z

/ok-to-test

codecov · 2020-07-17T15:38:01Z

Codecov Report

Merging #3960 into master will increase coverage by 0.41%.
The diff coverage is 42.00%.

@@            Coverage Diff             @@
##           master    #3960      +/-   ##
==========================================
+ Coverage   38.66%   39.08%   +0.41%     
==========================================
  Files         111      111              
  Lines        8718     8727       +9     
==========================================
+ Hits         3371     3411      +40     
+ Misses       4980     4940      -40     
- Partials      367      376       +9

server/container_create_linux.go

umohnani8 · 2020-09-16T01:59:04Z

/retest

haircommander · 2020-09-18T16:55:45Z

/retest
LGTM
PTAL @umohnani8 @kolyshkin @saschagrunert @mrunalp

umohnani8 · 2020-09-18T18:08:51Z

/lgtm

haircommander · 2020-09-18T18:27:38Z

/test integration_crun

server/container_create_linux.go

saschagrunert

/lgtm
/retest

openshift-ci-robot · 2020-09-21T08:34:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2020-09-21T13:19:43Z

/retest

haircommander · 2020-09-21T13:36:04Z

/lgtm

Signed-off-by: Skyler Clark <[email protected]>

haircommander · 2020-09-21T18:55:31Z

/retest

haircommander · 2020-09-22T19:52:29Z

/retest
/lgtm

openshift-ci-robot · 2020-09-22T21:13:47Z

@wgahnagl: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`bac4a3e`	link	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

haircommander · 2020-09-23T00:21:55Z

/retest

wgahnagl requested review from mrunalp and runcom as code owners July 16, 2020 18:19

openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jul 16, 2020

openshift-ci-robot requested a review from rhatdan July 16, 2020 18:21

openshift-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 16, 2020

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2020

wgahnagl force-pushed the container-refactoring-6 branch from aba6dff to 8c59fd8 Compare July 16, 2020 18:25

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 16, 2020

haircommander reviewed Jul 16, 2020

View reviewed changes

server/container_create_linux.go Outdated Show resolved Hide resolved

wgahnagl changed the title ~~container refactor~~ [WIP] container refactor Jul 16, 2020

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2020

wgahnagl force-pushed the container-refactoring-6 branch from d37b4e4 to 566e2f3 Compare July 17, 2020 18:55

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 17, 2020

wgahnagl force-pushed the container-refactoring-6 branch from 566e2f3 to 617a79d Compare July 17, 2020 18:59

wgahnagl changed the title ~~[WIP] container refactor~~ container refactor Jul 17, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2020

wgahnagl commented Jul 17, 2020

View reviewed changes

server/container_create_linux.go Show resolved Hide resolved

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 18, 2020

openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 16, 2020

wgahnagl force-pushed the container-refactoring-6 branch from 2630d0e to 3bd8eed Compare September 16, 2020 18:10

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 16, 2020

openshift-ci-robot assigned umohnani8 Sep 18, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020

haircommander reviewed Sep 18, 2020

View reviewed changes

server/container_create_linux.go Outdated Show resolved Hide resolved

saschagrunert approved these changes Sep 21, 2020

View reviewed changes

wgahnagl force-pushed the container-refactoring-6 branch from 3bd8eed to 0dd4178 Compare September 21, 2020 13:33

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020

openshift-ci-robot assigned haircommander Sep 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020

moves spec generation to container

bac4a3e

Signed-off-by: Skyler Clark <[email protected]>

wgahnagl force-pushed the container-refactoring-6 branch from 0dd4178 to bac4a3e Compare September 21, 2020 17:48

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020

openshift-merge-robot merged commit a705db4 into cri-o:master Sep 23, 2020

wgahnagl mentioned this pull request Feb 15, 2022

REQUEST: New membership for wgahnagl #5649

Closed

4 tasks

container refactor #3960

container refactor #3960

Uh oh!

Conversation

wgahnagl commented Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Jul 16, 2020

Uh oh!

Uh oh!

haircommander commented Jul 16, 2020

Uh oh!

codecov bot commented Jul 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

umohnani8 commented Sep 16, 2020

Uh oh!

haircommander commented Sep 18, 2020

Uh oh!

umohnani8 commented Sep 18, 2020

Uh oh!

haircommander commented Sep 18, 2020

Uh oh!

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 21, 2020

Uh oh!

haircommander commented Sep 21, 2020

Uh oh!

haircommander commented Sep 21, 2020

Uh oh!

haircommander commented Sep 21, 2020

Uh oh!

haircommander commented Sep 22, 2020

Uh oh!

openshift-ci-robot commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haircommander commented Sep 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wgahnagl commented Jul 16, 2020 •

edited

Loading

codecov bot commented Jul 17, 2020 •

edited

Loading

openshift-ci-robot commented Sep 22, 2020 •

edited

Loading