Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@giuseppe
Copy link
Member

@giuseppe giuseppe commented Jul 17, 2020

This reverts commit ffffdf8.

Signed-off-by: Giuseppe Scrivano [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a bug where a sudden reboot causes incomplete image writes. This could cause image storage to be corrupted, resulting in an error `layer not known`.

@giuseppe giuseppe requested review from mrunalp and runcom as code owners July 17, 2020 16:07
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Jul 17, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2020
@harche
Copy link
Contributor

harche commented Jul 17, 2020

/lgtm

@openshift-ci-robot
Copy link

@harche: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalind
Copy link
Collaborator

nalind commented Jul 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member

can you add a release note?

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 17, 2020
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #3972 into release-1.18 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.18    #3972   +/-   ##
=============================================
  Coverage         40.82%   40.82%           
=============================================
  Files               106      106           
  Lines              8703     8703           
=============================================
  Hits               3553     3553           
  Misses             4837     4837           
  Partials            313      313           

@openshift-merge-robot openshift-merge-robot merged commit b5e3b15 into cri-o:release-1.18 Jul 17, 2020
@mrunalp
Copy link
Member

mrunalp commented Jul 17, 2020

/cherrypick master

@openshift-cherrypick-robot

@mrunalp: new pull request created: #3975

Details

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants