-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[1.18] Revert "container_server: disable fdatasync() for atomic writes" #3972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.18] Revert "container_server: disable fdatasync() for atomic writes" #3972
Conversation
This reverts commit ffffdf8. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
/lgtm |
|
@harche: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
can you add a release note? |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #3972 +/- ##
=============================================
Coverage 40.82% 40.82%
=============================================
Files 106 106
Lines 8703 8703
=============================================
Hits 3553 3553
Misses 4837 4837
Partials 313 313 |
|
/cherrypick master |
|
@mrunalp: new pull request created: #3975 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit ffffdf8.
Signed-off-by: Giuseppe Scrivano [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?