Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set SELinux mount label for pod sandbox #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrunalp merged 3 commits into from
Mar 16, 2017
Merged

Set SELinux mount label for pod sandbox #391

mrunalp merged 3 commits into from
Mar 16, 2017

Conversation

@rhatdan
Copy link
Contributor

@rhatdan rhatdan commented Mar 15, 2017

The pause container is creating an AVC since the /dev/null device
is not labeled correctly. Looks like we are only setting the label of
the process not the label of the content inside of the container.
This change will label content in the pause container correctly and
eliminate the AVC.

Signed-off-by: Daniel J Walsh [email protected]

@mrunalp
Copy link
Member

mrunalp commented Mar 15, 2017

make lint failed:

110.50s$ make lint
checking lint
utils/utils.go:72:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
make: *** [lint] Error 1

@mrunalp
Copy link
Member

mrunalp commented Mar 15, 2017

It isn't related to this change though :/

@rhatdan
Copy link
Contributor Author

rhatdan commented Mar 15, 2017

@mrunalp Fixed the golint issue so this can get merged.

@mrunalp
Copy link
Member

mrunalp commented Mar 15, 2017

@rhatdan Thanks! I will wait for travis builds to complete.

@mrunalp
Copy link
Member

mrunalp commented Mar 15, 2017

Build seems to have timed-out. Restarted.

@mrunalp
Copy link
Member

mrunalp commented Mar 15, 2017

Build failure now:

utils/utils.go:72: too many arguments to return

@mrunalp mrunalp added this to the 0.2 milestone Mar 16, 2017
@mrunalp
Copy link
Member

mrunalp commented Mar 16, 2017

@rhatdan gofmt check failed:

make gofmt
!!! 'gofmt -s' needs to be run on the following files: 
./utils/utils.go
make: *** [gofmt] Error 1
The command "make gofmt" exited with 2.

rhatdan added 2 commits March 16, 2017 14:09
@rhatdan
Fix golint error
bf6c414 
golint has figured out an optimization that is blocking other pull requests.
This fixes the golint issue.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Set SELinux mount label for pod sandbox
ff950a8 
The pause container is creating an AVC since the /dev/null device
is not labeled correctly.  Looks like we are only setting the label of
the process not the label of the content inside of the container.
This change will label content in the pause container correctly and
eliminate the AVC.

Signed-off-by: Daniel J Walsh <[email protected]>
@mrunalp
Copy link
Member

mrunalp commented Mar 16, 2017

Passed :)
LGTM

@mrunalp mrunalp merged commit 792f585 into cri-o:master Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@rhatdan @mrunalp @k8s-ci-robot