Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improves container memory usage stats #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 31, 2020
Merged

Improves container memory usage stats #3933

openshift-merge-robot merged 1 commit into from
Jul 31, 2020

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Jul 7, 2020 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Allows viewing of stats by individual container instead of the whole pod

Which issue(s) this PR fixes:

Fixes #3580

Special notes for your reviewer:

Does this PR introduce a user-facing change?

How the stats display for containers

fixed a bug where crictl only showed pod level stats, not container level stats.

@wgahnagl wgahnagl requested review from mrunalp and runcom as code owners July 7, 2020 15:45
@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Jul 7, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2020

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2020
@wgahnagl wgahnagl force-pushed the pod-memory-usage branch from f214dd6 to fdaab4c Compare July 7, 2020 15:49
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 7, 2020
@haircommander
Copy link
Member

haircommander commented Jul 7, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2020
haircommander
haircommander reviewed Jul 7, 2020
View reviewed changes
haircommander
haircommander reviewed Jul 7, 2020
View reviewed changes
@haircommander
Copy link
Member

haircommander commented Jul 7, 2020

/retest

@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #3933 into master will increase coverage by 0.06%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
+ Coverage   40.87%   40.93%   +0.06%     
==========================================
  Files         109      109              
  Lines        8850     8859       +9     
==========================================
+ Hits         3617     3626       +9     
  Misses       4903     4903              
  Partials      330      330

@wgahnagl wgahnagl force-pushed the pod-memory-usage branch from fdaab4c to 66eb76d Compare July 7, 2020 17:07
@haircommander
Copy link
Member

haircommander commented Jul 7, 2020 •
edited
Loading

you've got gitvalidation errors too https://app.circleci.com/pipelines/github/cri-o/cri-o/4425/workflows/2419657b-4a78-46ab-920e-56995a81fcd8/jobs/68082/steps
"has whitespace errors. See git show --check 66eb76d356824880c2d86b8f2a50fd6dc9fc494f"

@wgahnagl wgahnagl force-pushed the pod-memory-usage branch from 66eb76d to 930ab58 Compare July 7, 2020 17:20
haircommander
haircommander reviewed Jul 7, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 7, 2020
@wgahnagl wgahnagl force-pushed the pod-memory-usage branch from 2b48ad9 to 100865f Compare July 7, 2020 17:37
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 7, 2020
haircommander
haircommander reviewed Jul 7, 2020
View reviewed changes
@wgahnagl wgahnagl force-pushed the pod-memory-usage branch 2 times, most recently from 9c58c27 to 85e3f02 Compare July 7, 2020 17:42
kolyshkin
kolyshkin reviewed Jul 15, 2020
View reviewed changes
kolyshkin
kolyshkin reviewed Jul 15, 2020
View reviewed changes
kolyshkin
kolyshkin reviewed Jul 15, 2020
View reviewed changes
kolyshkin
kolyshkin reviewed Jul 15, 2020
View reviewed changes
kolyshkin
kolyshkin reviewed Jul 15, 2020
View reviewed changes
@haircommander
Copy link
Member

haircommander commented Jul 17, 2020

/test e2e-aws

@haircommander
Copy link
Member

haircommander commented Jul 17, 2020

/hold

@wgahnagl can you address @kolyshkin comments above?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@saschagrunert
Copy link
Member

saschagrunert commented Jul 22, 2020

One more
/retest

@haircommander
Copy link
Member

haircommander commented Jul 22, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@saschagrunert
Copy link
Member

saschagrunert commented Jul 23, 2020

/retest

2 similar comments
@haircommander
Copy link
Member

haircommander commented Jul 28, 2020

/retest

@haircommander
Copy link
Member

haircommander commented Jul 28, 2020

/retest

@haircommander
Copy link
Member

haircommander commented Jul 29, 2020

c'mon prow

@haircommander
Copy link
Member

haircommander commented Jul 29, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 29, 2020
@haircommander
Copy link
Member

haircommander commented Jul 30, 2020

/test e2e-aws

2 similar comments
@haircommander
Copy link
Member

haircommander commented Jul 30, 2020

/test e2e-aws

@haircommander
Copy link
Member

haircommander commented Jul 31, 2020

/test e2e-aws

@haircommander
Copy link
Member

haircommander commented Jul 31, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit fd6444b into cri-o:master Jul 31, 2020
@haircommander haircommander mentioned this pull request Aug 3, 2020
Merged
@haircommander haircommander mentioned this pull request Jan 13, 2021
Closed
@wgahnagl wgahnagl mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolyshkin kolyshkin kolyshkin left review comments

@haircommander haircommander haircommander left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@nalind nalind Awaiting requested review from nalind

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

@umohnani8 umohnani8

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crictl stats return pod memory usage not per container

7 participants

@wgahnagl @openshift-ci-robot @haircommander @umohnani8 @saschagrunert @kolyshkin @openshift-merge-robot