Propagate the sandbox DNS mount point to pod containers #404
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2017 15:28
When we get a pod with DNS settings, we need to build a resolv.conf file and mount it in all pod containers. In order to do that, we have to track the built resolv.conf file and store/load it. Signed-off-by: Samuel Ortiz <[email protected]>
When a pod sandbox comes with DNS settings, the resulting resolv.conf file needs to be bind mounted in all pod containers under /etc/resolv.conf. Signed-off-by: Samuel Ortiz <[email protected]>
Author
|
cc @mcastelino |
Member
|
@sameo The fix looks fine. I will wait for the tests to go through. Thanks! |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pod sandboxes come with DNS settings, we build and bind mount a
resolv.conffile into the pod sandbox rootfs.In order for pod internal DNS to work, we have to propagate that mount point to all pod containers.
Fixes #402