Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: reduce flakes #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Sep 1, 2020
Merged

test: reduce flakes #4141

openshift-merge-robot merged 2 commits into from
Sep 1, 2020

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Aug 31, 2020 •
edited
Loading

What type of PR is this?

/kind flake

What this PR does / why we need it:

deflake stats test by making the two containers different
deflake all tests by ignoring ENOENT on the shm unmount (as we're allowed to attempt to UnmountShm() multiple times)
Signed-off-by: Peter Hunt [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander
test: deflake stats test
bc9dd6f 
it is much less likely two containers will use the same amount of memory if they're different containers

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/flake Categorizes issue or PR as related to a flaky test. labels Aug 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020 •
edited
Loading

Codecov Report

Merging #4141 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #4141   +/-   ##
=======================================
  Coverage   40.42%   40.42%           
=======================================
  Files         110      110           
  Lines        9331     9331           
=======================================
  Hits         3772     3772           
  Misses       5209     5209           
  Partials      350      350

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
sandbox: ignore enoent on shm unmount
525d5b7 
as it can be unmounted multiple times and should not result in an error

Signed-off-by: Peter Hunt <[email protected]>
@haircommander haircommander changed the title test: deflake stats test test: deflake integration rhel Aug 31, 2020
@haircommander
Copy link
Member Author

haircommander commented Aug 31, 2020

/test integration_rhel

1 similar comment
@haircommander
Copy link
Member Author

haircommander commented Sep 1, 2020

/test integration_rhel

@haircommander
Copy link
Member Author

haircommander commented Sep 1, 2020

/retest

@haircommander haircommander changed the title test: deflake integration rhel test: reduce flakes Sep 1, 2020
@haircommander
Copy link
Member Author

haircommander commented Sep 1, 2020

/retest

@mrunalp
Copy link
Member

mrunalp commented Sep 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@haircommander
Copy link
Member Author

haircommander commented Sep 1, 2020

/cherry-pick release-1.19

this run seems to be hit negatively by a bug fixed by #4146

/retest

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 1, 2020

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

this run seems to be hit negatively by a bug fixed by #4146

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

haircommander commented Sep 1, 2020

/test e2e_crun

@fidencio
Copy link
Contributor

fidencio commented Sep 1, 2020

LGTM

@haircommander
Copy link
Member Author

haircommander commented Sep 1, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit da77921 into cri-o:master Sep 1, 2020
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 1, 2020

@haircommander: #4141 failed to apply on top of branch "release-1.19":

Applying: test: deflake stats test
Using index info to reconstruct a base tree...
M	test/stats.bats
Falling back to patching base and 3-way merge...
Auto-merging test/stats.bats
CONFLICT (content): Merge conflict in test/stats.bats
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: deflake stats test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-1.19

this run seems to be hit negatively by a bug fixed by #4146

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander haircommander mentioned this pull request Sep 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@haircommander @openshift-ci-robot @mrunalp @openshift-cherrypick-robot @fidencio @openshift-merge-robot