Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The new configuration values in cri-tools v1.19.0 should be added to our vendored config as well.

Which issue(s) this PR fixes:

Follow-up of #4150

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- Updated `crictl.yaml` configuration inside the repository to reflect cri-tools v1.19.0 changes

The new configuration values in cri-tools v1.19.0 should be added to our
vendored config as well.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 3, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #4162 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4162   +/-   ##
=======================================
  Coverage   40.76%   40.76%           
=======================================
  Files         111      111           
  Lines        9494     9494           
=======================================
  Hits         3870     3870           
  Misses       5248     5248           
  Partials      376      376           

@fidencio
Copy link
Contributor

fidencio commented Sep 4, 2020

LGTM

@haircommander
Copy link
Member

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2020

@saschagrunert: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws ca1c466 link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saschagrunert
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 8d04865 into cri-o:master Sep 11, 2020
@saschagrunert saschagrunert deleted the crictl-yaml branch September 11, 2020 09:20
@saschagrunert
Copy link
Member Author

/cherry-pick release-1.19

@openshift-cherrypick-robot

@saschagrunert: new pull request created: #4185

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants