add the integration tests for handling default runtime #4172
Conversation
|
Hi @harche. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@saschagrunert addressing this comment, #4097 (comment) |
Signed-off-by: Harshal Patil <[email protected]>
6e592b7 to
3fd6ff7
Compare
Codecov Report
@@ Coverage Diff @@
## master #4172 +/- ##
=======================================
Coverage 40.92% 40.92%
=======================================
Files 111 111
Lines 9512 9512
=======================================
Hits 3893 3893
Misses 5242 5242
Partials 377 377 |
saschagrunert
left a comment
There was a problem hiding this comment.
Nice!
/ok-to-test
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harche, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
@harche: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Signed-off-by: Harshal Patil [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Missing integration test for #4097
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?