Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update nix pin with make nixpkgs #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 26, 2020
Merged

Update nix pin with make nixpkgs #4184

openshift-merge-robot merged 1 commit into from
Sep 26, 2020

Conversation

@hswong3i
Copy link
Contributor

@hswong3i hswong3i commented Sep 11, 2020 •
edited
Loading

Signed-off-by: Wong Hoi Sing Edison [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update nix pin with `make nixpkgs`

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 11, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2020

Hi @hswong3i. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 11, 2020 •
edited
Loading

Codecov Report

Merging #4184 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4184   +/-   ##
=======================================
  Coverage   38.75%   38.75%           
=======================================
  Files         111      111           
  Lines        8698     8698           
=======================================
  Hits         3371     3371           
  Misses       4963     4963           
  Partials      364      364

saschagrunert
saschagrunert approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 11, 2020
saschagrunert
saschagrunert approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschagrunert
Copy link
Member

saschagrunert commented Sep 12, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2020
@hswong3i
Copy link
Contributor Author

hswong3i commented Sep 12, 2020

/retest

@hswong3i hswong3i force-pushed the master-linux-amd64 branch 2 times, most recently from 2b497f7 to 9751fec Compare September 13, 2020 01:04
@saschagrunert
Copy link
Member

saschagrunert commented Sep 14, 2020

/retest

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Sep 14, 2020

LGTM
assuming happy tests

@hswong3i hswong3i force-pushed the master-linux-amd64 branch 2 times, most recently from 41ee79c to d54b8c5 Compare September 17, 2020 08:48
@hswong3i
Update nix pin with make nixpkgs
deba258 
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@kolyshkin kolyshkin mentioned this pull request Sep 18, 2020
Closed
@hswong3i
Copy link
Contributor Author

hswong3i commented Sep 26, 2020

/retest

@saschagrunert
Copy link
Member

saschagrunert commented Sep 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hswong3i, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4e3bae4 into cri-o:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hswong3i @openshift-ci-robot @saschagrunert @TomSweeneyRedHat @openshift-merge-robot