-
Notifications
You must be signed in to change notification settings - Fork 1.1k
oci: improve error message for verifyPid() #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oci: improve error message for verifyPid() #4139
Conversation
saschagrunert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Integration RHEL seems broken since quite some time :-/ |
Signed-off-by: Peter Hunt <[email protected]>
f8004df to
635ab5f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4139 +/- ##
==========================================
+ Coverage 40.42% 40.44% +0.01%
==========================================
Files 110 110
Lines 9331 9334 +3
==========================================
+ Hits 3772 3775 +3
Misses 5209 5209
Partials 350 350 |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/cherry-pick release-1.19 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e_rhel |
|
/retest |
|
/test integration_rhel |
|
/retest |
|
/test integration_rhel |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test integration_crun |
|
@haircommander: new pull request created: #4154 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?