read image config from docker v2s1 manifests #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f83b53 to
bb43784
Compare
|
@runcom Will test it today, sorry for the lag. |
|
@runcom with this PR and the following patch: https://gist.github.com/sameo/dbb86800472f57f5333c31acfc07dcb0 I can deploy my k8s cluster and the pause image config no longer seems to be empty. |
Member
Author
|
@sameo PTAL at the latest commit (maybe re-testing everything out if it's not an hassle for you) |
|
@runcom Re-tested with the 2 commits from your branch and it still works fine. |
|
LGTM |
Signed-off-by: Antonio Murdaca <[email protected]>
Now that the image package has fixes to support docker images v2s1, we can remove our buildOCIProcessARgs() hack for empty image configs and simplify this routine. Signed-off-by: Samuel Ortiz <[email protected]> Signed-off-by: Antonio Murdaca <[email protected]>
63b32f9 to
c89cc87
Compare
Member
Author
|
This is ready to review and merge @mrunalp |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #395
@sameo could you test this patch out and see if it fixes the issue for you? This is still blocked on containers/image#259
Signed-off-by: Antonio Murdaca [email protected]