removes excessive runs from pod.bats #4257
Conversation
|
Hi @wgahnagl. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
aca8cbd to
9a5891c
Compare
|
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4257 +/- ##
=======================================
Coverage 38.57% 38.57%
=======================================
Files 111 111
Lines 8897 8897
=======================================
Hits 3432 3432
Misses 5081 5081
Partials 384 384 |
9a5891c to
c156ba5
Compare
c156ba5 to
3ea4d92
Compare
f5e4900 to
d4bddcd
Compare
For example, i.e. the second cleanup should not be part of the test as we're checking the pod with the same name can be recreated, and not checking that the second pod can be removed. |
so a reader would see where the changes are made right away. As someone who reads git history a lot, I can attest that if the message starts with a file name, directory, subsystem name, package name, top-level feature or something like this, it makes it easier to visually filter what you're looking for. Of course this is super minor. I wish I can point out to some kind of "best practices" doc for git commits but I don't have any :( |
0f1beff to
f853472
Compare
Signed-off-by: Skyler Clark <[email protected]>
f853472 to
dbd3dbe
Compare
test/pod.bats
Outdated
| run systemctl list-units --type=slice | ||
| echo "$output" | ||
| [ "$status" -eq 0 ] | ||
| crictl runp "$TESTDIR"/sandbox_systemd_cgroup_parent.json |
dbd3dbe to
a7b5ef7
Compare
test/pod.bats
Outdated
| echo "$output" | grep 'TimeoutStopUSec=' || true # show | ||
| echo "$output" | grep -q '^TimeoutStopUSec=1min 28s$' # check |
There was a problem hiding this comment.
Hmm, can't understand why these two lines have changed
|
@wgahnagl: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a7b5ef7 to
41e59c1
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, mrunalp, wgahnagl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wgahnagl could you edit and add release note? |
Signed-off-by: Skyler Clark <[email protected]>
41e59c1 to
2ba9656
Compare
|
/retest |
|
/lgtm (from kir's review) |
|
/lgtm |
|
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
simplifies the pod.bats file by removing excessive use of run
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?