Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.18] server: cleanup container in runtime after failed creation #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-1.18] server: cleanup container in runtime after failed creation #4205

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 16, 2020

This is an automated cherry-pick of #4201

/assign haircommander

Fixed a bug where a container creation failure caused that container to leak in the runtime

@haircommander
server: cleanup container in runtime after failed creation
76388ea 
otherwise, we leak containers in runc

Signed-off-by: Peter Hunt <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 16, 2020
Merged
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 16, 2020
saschagrunert
saschagrunert approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020
@saschagrunert saschagrunert changed the title [release-1.18] [1.19] server: cleanup container in runtime after failed creation [release-1.18] server: cleanup container in runtime after failed creation Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #4205 into release-1.18 will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.18    #4205      +/-   ##
================================================
- Coverage         40.73%   40.70%   -0.03%     
================================================
  Files               106      106              
  Lines              8755     8760       +5     
================================================
  Hits               3566     3566              
- Misses             4872     4877       +5     
  Partials            317      317

@haircommander
Copy link
Member

haircommander commented Sep 16, 2020

/retest

@mrunalp
Copy link
Member

mrunalp commented Sep 16, 2020

/test integration_crun

@haircommander
Copy link
Member

haircommander commented Sep 16, 2020

/retest

@haircommander
Copy link
Member

haircommander commented Sep 16, 2020

/test integration_crun

@haircommander
Copy link
Member

haircommander commented Sep 17, 2020

/retest

1 similar comment
@haircommander
Copy link
Member

haircommander commented Sep 18, 2020

/retest

@haircommander
Copy link
Member

haircommander commented Sep 24, 2020

/test integration_crun

@sferich888
Copy link

sferich888 commented Sep 24, 2020

Relates to https://bugzilla.redhat.com/show_bug.cgi?id=1878532 for tracking purposes.

@umohnani8
Copy link
Member

umohnani8 commented Sep 30, 2020

/retest
LGTM

@haircommander
Copy link
Member

haircommander commented Sep 30, 2020

/test integration_fedora

@haircommander
Copy link
Member

haircommander commented Sep 30, 2020

/retest

1 similar comment
@haircommander
Copy link
Member

haircommander commented Sep 30, 2020

/retest

@haircommander
Copy link
Member

haircommander commented Oct 1, 2020

/test integration_fedora

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2020

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 76388ea link /test integration_cgroupv2
ci/openshift-jenkins/integration_fedora 76388ea link /test integration_fedora

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Oct 1, 2020

replacing with #4237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@nalind nalind Awaiting requested review from nalind

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @haircommander @mrunalp @sferich888 @umohnani8 @saschagrunert