[1.18] test/config: fix "config dir should fail with invalid option" #4222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes this test fails like this:
> not ok 11 config dir should fail with invalid option
> (in test file ./config.bats, line 38)
> `RES=$(cat "$CRIO_LOG")' failed
> cat: /tmp/tmp.nho2aP6lqh/crio.log: No such file or directory
> unable to decode configuration /tmp/tmp.nho2aP6lqh/crio.conf: Near line 2 (last key parsed 'crio.runtime.log_level'): expected value but found "info" instead
The reason it fails is logs are written by using tee,
which for some reason is run in a subshell, and it looks
like a race between the main shell and the subshell.
Anyway, using tee is not needed here. Simplify it by using run,
and add a check for non-zero exit code.
The second proble is, the test is not doing what it supposed to.
Judging by the test name ("config dir should fail"), it seems the test
should write a correct log_level value to the main config file, a wrong
value to a file under crio.conf.d, and check that crio fails.
The problem is, the value in main file is wrong as well it is not quoted.
Fix the test so the main config file has the correct log_level value.
Fix the output check to look for the specific bad key.
Signed-off-by: Kir Kolyshkin <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #4222 +/- ##
================================================
- Coverage 40.73% 38.73% -2.00%
================================================
Files 106 106
Lines 8755 7934 -821
================================================
- Hits 3566 3073 -493
+ Misses 4872 4562 -310
+ Partials 317 299 -18 |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
|
LGTM |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes this test fails like this:
The reason it fails is logs are written by using tee,
which for some reason is run in a subshell, and it looks
like a race between the main shell and the subshell.
Anyway, using tee is not needed here. Simplify it by using run,
and add a check for non-zero exit code.
The second proble is, the test is not doing what it supposed to.
Judging by the test name ("config dir should fail"), it seems the test
should write a correct log_level value to the main config file, a wrong
value to a file under crio.conf.d, and check that crio fails.
The problem is, the value in main file is wrong as well it is not quoted.
Fix the test so the main config file has the correct log_level value.
Fix the output check to look for the specific bad key.
Signed-off-by: Kir Kolyshkin [email protected]
What type of PR is this?
/kind flake
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
cherry-pick of #4220
Does this PR introduce a user-facing change?