runtime_vm: set Pid and InitPid for VM runtimes #4225
Conversation
|
Hi @liubin. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #4225 +/- ##
==========================================
- Coverage 39.06% 39.05% -0.02%
==========================================
Files 111 111
Lines 8731 8734 +3
==========================================
Hits 3411 3411
- Misses 4944 4947 +3
Partials 376 376 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liubin, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
oops, thanks for the fix @liubin ! LGTM, though you need to fix the issues in |
If Pid or InitPid is not set correctly, then c.Alive() will return false, and all calls depending on c.Alive() will fail. Fixes: cri-o#4224 Signed-off-by: bin liu <[email protected]>
6d0c6b8 to
6913515
Compare
Sorry, fixed. |
|
@liubin: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/cherry-pick release-1.18 |
|
@fidencio: new pull request created: #4270 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: bin liu [email protected]
What type of PR is this?
What this PR does / why we need it:
If Pid or InitPid is not set correctly, then c.Alive()
will return false, and all calls depending on c.Alive()
will fail.
Which issue(s) this PR fixes:
Fixes #4224
Special notes for your reviewer:
Does this PR introduce a user-facing change?