[1.18] Fix bogus CI test failures on RHEL7 #4232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following failure happens in CI on RHEL7 from time to time: > removing the pod sandbox "0d5bf5eeb0048bb70ab8ee9bca0a497e216a6c6cfa42507a8d735f61c825784d": rpc error: code = Unknown desc = unable to remove managed namespaces: Removing namespaces encountered the following errors [unlinkat /var/run/netns/0376543d-4917-417f-b406-7e8ab07cb847: device or resource busy] (with different test cases and different namespaces). RHEL7 kernel has upstream commit [1] backported, but the feature is controlled by a sysctl and is off by default. For the feature to work, one needs to set fs.may_detach_mounts = 1. On production RHEL7 systems, this is done by runc rpm (see [2]), but we're not using those rpms for CI, so we have to set the sysctl manually. Add an integration test case to check the sysctl is set. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8ed936b5671bfb33d89bc60bdcc7cf0470ba52fe [2] https://bugzilla.redhat.com/show_bug.cgi?id=1823374#c17 Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit a2bc9d3) Signed-off-by: Kir Kolyshkin <[email protected]>
Member
|
LGTM, we won't hit similar issues here because we don't |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #4232 +/- ##
================================================
- Coverage 40.73% 38.73% -2.00%
================================================
Files 106 106
Lines 8755 7934 -821
================================================
- Hits 3566 3073 -493
+ Misses 4872 4562 -310
+ Partials 317 299 -18 |
mrunalp
approved these changes
Sep 29, 2020
Member
|
/retest |
saschagrunert
approved these changes
Sep 30, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
Member
|
/lgtm |
Member
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of #4217 to release-1.17 branch
What type of PR is this?
/kind flake
What this PR does / why we need it:
The following failure happens in CI on RHEL7 from time to time:
(with different test cases and different namespaces).
RHEL7 kernel has upstream commit [1] backported, but the feature is
controlled by a sysctl and is off by default. For the feature to work,
one needs to set fs.may_detach_mounts = 1.
On production RHEL7 systems, this is done by runc rpm (see [2]), but
we're not using those rpms for CI, so we have to set the sysctl
manually.
Add an integration test case to check the sysctl is set.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8ed936b5671bfb33d89bc60bdcc7cf0470ba52fe
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1823374#c17
Which issue(s) this PR fixes:
Fixes: #3996
Some more notes at #4210
Special notes for your reviewer:
Does this PR introduce a user-facing change?