[1.18] server: cleanup container in runtime after failed creation #4237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, we leak containers in runc Signed-off-by: Peter Hunt <[email protected]>
Commit 39aef1a broke the command exit code check, as `run` always returns 0. Fix: do not use run. This might help some CI flakes. Signed-off-by: Kir Kolyshkin <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #4237 +/- ##
================================================
- Coverage 38.73% 38.70% -0.03%
================================================
Files 106 106
Lines 7934 7939 +5
================================================
Hits 3073 3073
- Misses 4562 4567 +5
Partials 299 299 |
Member
Author
|
/test integration_fedora |
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-automated cherry-pick of #4201
/kind bug
it also includes 5bce748 to hopefully fix integration_fedora flakes on this branch