Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.19] bump containers/storage to 1.20.5 to fix EINTR #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 17, 2020
Merged

[1.19] bump containers/storage to 1.20.5 to fix EINTR #4340

openshift-merge-robot merged 1 commit into from
Nov 17, 2020

Conversation

@kolyshkin
Copy link
Collaborator

@kolyshkin kolyshkin commented Nov 3, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

(this is similar to #4334 but for 1.19 release branch)

This is mostly to have the backport of containers/storage#757 brought in
which should fix occasional CI failures (and probably real failures, too).

Which issue(s) this PR fixes:

time="2020-11-02T19:00:03Z" level=fatal msg="creating container: rpc error: code = Unknown desc = error creating an ID-mapped copy of layer "01d6f430ddfdf1203b505fbb03c6479802a3366609d5e0231a30f85f412f873d": exit status 1: error during chown: storage-chown-by-maps: chown("lib/apk/db/scripts.tar"): lchown lib/apk/db/scripts.tar: interrupted system call"

periodically caught by CI

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fix occasional "chown: interrupted system call" error on container creation.

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 3, 2020
@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 3, 2020
@kolyshkin kolyshkin changed the title 1.19 bump ct storage [1.19] bump containers/storage to 1.20.5 to fix EINTR Nov 3, 2020
@kolyshkin kolyshkin changed the base branch from master to release-1.19 November 3, 2020 10:52
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 3, 2020

/retest

@kolyshkin kolyshkin force-pushed the 1.19-bump-ct-storage branch from 1062ef4 to 99cd712 Compare November 3, 2020 10:58
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 3, 2020
@kolyshkin kolyshkin mentioned this pull request Nov 3, 2020
Merged
@codecov
Copy link

codecov bot commented Nov 3, 2020 •
edited
Loading

Codecov Report

Merging #4340 (462253c) into release-1.19 (571103d) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.19    #4340   +/-   ##
=============================================
  Coverage         39.53%   39.53%           
=============================================
  Files               110      110           
  Lines              8300     8300           
=============================================
  Hits               3281     3281           
  Misses             4692     4692           
  Partials            327      327

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Nov 3, 2020

LGTM
assuming happy tests

@haircommander
Copy link
Member

haircommander commented Nov 3, 2020

/retest
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 3, 2020

build-static step failed in pipeline with this (from here

cri-o> ./.cache/store/.links/1w3sqaz9rca7jxiinbma87prdkx23s95k7wvv9gydvfsv2im5dz6: unsupported interpreter directive "/usr/bin/env -S nix-build --no-out-link" (set dontPatchShebangs=1 and handle shebang patching yourself)

and I don't have a slightest idea of what it is.

Restarted.

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 7, 2020

/retest

still don't know what to do with nix build

@kolyshkin
[1.19] vendor: bump containers/storage to v1.20.5
462253c 
This is mostly to have backport of containers/storage#757
which should fix occasional CI failures.

Brought to you by

	go get github.com/containers/[email protected]
	go mod vendor
	go mod tidy
	git add vendor
	git commit -as

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin force-pushed the 1.19-bump-ct-storage branch from 99cd712 to 462253c Compare November 16, 2020 20:43
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 16, 2020

Other PRs from 1.19 branch were merged with the same CI issue (pipeline static nix build) not solved (e.g. #4355), so I guess this one can also be merged.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 16, 2020 •
edited
Loading

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 462253c link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

saschagrunert
saschagrunert approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kolyshkin, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member

haircommander commented Nov 17, 2020

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit f51f94a into cri-o:release-1.19 Nov 17, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kolyshkin @TomSweeneyRedHat @haircommander @openshift-merge-robot @openshift-ci-robot @saschagrunert