Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.18] vendor: bump containers/storage to 1.20.5 to fix EINTR #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kolyshkin wants to merge 1 commit into from
Closed

[1.18] vendor: bump containers/storage to 1.20.5 to fix EINTR #4341

kolyshkin wants to merge 1 commit into from

Conversation

@kolyshkin
Copy link
Collaborator

@kolyshkin kolyshkin commented Nov 3, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

(this is similar to #4334 but for 1.19 release branch)

This is mostly to have the backport of containers/storage#757 brought in
which should fix occasional CI failures (and probably real failures, too).

Which issue(s) this PR fixes:

time="2020-11-02T19:00:03Z" level=fatal msg="creating container: rpc error: code = Unknown desc = error creating an ID-mapped copy of layer "01d6f430ddfdf1203b505fbb03c6479802a3366609d5e0231a30f85f412f873d": exit status 1: error during chown: storage-chown-by-maps: chown("lib/apk/db/scripts.tar"): lchown lib/apk/db/scripts.tar: interrupted system call"

periodically caught by CI

Special notes for your reviewer:

We have used containers/storage v1.19.2, and the change to 1.20.5 is somewhat major, so we need to decide what to do:

Does this PR introduce a user-facing change?

Fix occasional "chown: interrupted system call" error on container creation.

@kolyshkin
[1.18] vendor: bump containers/storage to 1.20.5
3381107 
This is mostly to have backport of containers/storage#757
which should fix occasional CI failures.

Brought to you by

	go get github.com/containers/[email protected]
	go mod vendor
	go mod tidy
	git add vendor
	git commit -as

Signed-off-by: Kir Kolyshkin <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Nov 3, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kolyshkin
To complete the pull request process, please assign mrunalp after the PR has been reviewed.
You can assign the PR to them by writing /assign @mrunalp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kolyshkin kolyshkin mentioned this pull request Nov 3, 2020
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 3, 2020

@kolyshkin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 3381107 link /test integration_cgroupv2
ci/openshift-jenkins/critest_fedora 3381107 link /test critest_fedora
ci/openshift-jenkins/e2e_fedora 3381107 link /test e2e_fedora
ci/openshift-jenkins/integration_crun 3381107 link /test integration_crun
ci/openshift-jenkins/e2e_crun_cgroupv2 3381107 link /test e2e_cgroupv2
ci/openshift-jenkins/integration_fedora 3381107 link /test integration_fedora
ci/openshift-jenkins/e2e_crun 3381107 link /test e2e_crun
ci/openshift-jenkins/e2e_features_fedora 3381107 link /test e2e_features_fedora
ci/openshift-jenkins/integration_rhel 3381107 link /test integration_rhel
ci/openshift-jenkins/e2e_rhel 3381107 link /test e2e_rhel
ci/openshift-jenkins/e2e_features_rhel 3381107 link /test e2e_features_rhel
ci/openshift-jenkins/critest_rhel 3381107 link /test critest_rhel
ci/prow/e2e-aws 3381107 link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Nov 3, 2020

LGTM
but something is upsetting the test apple cart

@haircommander
Copy link
Member

haircommander commented Nov 3, 2020

1.18 should still be built with go 1.13, so I am not sure we need this here

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 3, 2020

1.18 should still be built with go 1.13, so I am not sure we need this here

So, go 1.14 did not introduce a way to have EINTR returned by a syscall -- it greatly increased the probability of getting it. A process can still get EINTR if someone sends a signal to it (say, SIGUSR1 to get a goroutine stack dump).

I agree this is of much less concern though.

@kolyshkin kolyshkin closed this Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@haircommander haircommander Awaiting requested review from haircommander

@sameo sameo Awaiting requested review from sameo

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kolyshkin @openshift-ci-robot @openshift-merge-robot @TomSweeneyRedHat @haircommander