Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DO NOT MERGE] testing apparmor critest fix #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kolyshkin wants to merge 2 commits into from
Closed

[DO NOT MERGE] testing apparmor critest fix #4366

kolyshkin wants to merge 2 commits into from

Conversation

@kolyshkin
Copy link
Collaborator

@kolyshkin kolyshkin commented Nov 12, 2020 •
edited
Loading

Checking if #4334 (comment) (presumably caused by containers/storage#743) is being fixed by kubernetes-sigs/cri-tools#682

@kolyshkin
vendor: bump containers/storage to v1.23.9
2d812b4 
This is mostly to have containers/storage#757
which should fix occasional CI failures.

Signed-off-by: Kir Kolyshkin <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2020

@kolyshkin: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 12, 2020
@kolyshkin kolyshkin changed the title [DO NOT MERGE] testing torage critest fix [DO NOT MERGE] testing apparmor critest fix Nov 12, 2020
@kolyshkin kolyshkin mentioned this pull request Nov 12, 2020
Merged
@codecov
Copy link

codecov bot commented Nov 12, 2020 •
edited
Loading

Codecov Report

Merging #4366 (348ada3) into master (943f033) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4366   +/-   ##
=======================================
  Coverage   39.36%   39.36%           
=======================================
  Files         112      112           
  Lines        8825     8825           
=======================================
  Hits         3474     3474           
  Misses       4965     4965           
  Partials      386      386

@kolyshkin kolyshkin force-pushed the storage-critest-fix branch 2 times, most recently from 482852a to 2e4c990 Compare November 12, 2020 18:17
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 12, 2020

Seems like it's working (integration-critest passed). Let's finish all the tests.

/retest

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 12, 2020

OK it looks like the fix is working, but I am seeing another problem with crictl: many tests are now failing with messages like

time="2020-11-12T20:23:35Z" level=fatal msg="connect: connect endpoint 'unix:///tmp/tmp.6oNsSQYLOQ/crio.sock', make sure you are running as root and the endpoint has been started: context deadline exceeded"
time="2020-11-12T20:23:56Z" level=fatal msg="running container: creating container failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded"

I suspect it is caused by kubernetes-sigs/cri-tools@7ceada8 -- the part of it which adds defer cancel() statements. Reverting it now; @saschagrunert PTAL

@kolyshkin kolyshkin mentioned this pull request Nov 12, 2020
Merged
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 12, 2020

I am seeing another problem with crictl: many tests are now failing with messages like

time="2020-11-12T20:23:35Z" level=fatal msg="connect: connect endpoint 'unix:///tmp/tmp.6oNsSQYLOQ/crio.sock', make sure you are running as root and the endpoint has been started: context deadline exceeded"
time="2020-11-12T20:23:56Z" level=fatal msg="running container: creating container failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded"

Figured it out; see kubernetes-sigs/cri-tools#683

@kolyshkin
[debug] test critest fix
348ada3 
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 12, 2020

ci/prow/* failures are caused by

http://vault.centos.org/centos/7/updates/Source/repodata/repomd.xml: [Errno 14] HTTP Error 404 - Not Found

Indeed it's not there anymore. Not sure though why we're using centos 7...

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 12, 2020

Interesting it's there in the mirrors, e.g. https://archive.kernel.org/centos-vault/centos/7/updates/Source/repodata/ but gone from the main site (http://vault.centos.org/centos/7/updates/Source/).

@kolyshkin kolyshkin mentioned this pull request Nov 12, 2020
Closed
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 12, 2020

OK both fixes, i.e.

are working

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 12, 2020

OK both fixes, i.e.

are working

@saschagrunert can you merge both and cut a release please? This will help me with #4334 which will help with CI flakes (of EAGAIN type) that we currently suffer from.

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 13, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 13, 2020 •
edited
Loading

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 348ada3 link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 13, 2020

While we're at it, let's check that centos repo is fixed.

/retest

@kolyshkin kolyshkin mentioned this pull request Nov 13, 2020
Merged
@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 13, 2020

we're done here

@kolyshkin kolyshkin closed this Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@haircommander haircommander Awaiting requested review from haircommander

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin @openshift-ci-robot @openshift-merge-robot