Thanks to visit codestin.com
Credit goes to github.com

Skip to content

vendor: update syndtr/gocapability #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aanm wants to merge 1 commit into from
Closed

vendor: update syndtr/gocapability #4463

aanm wants to merge 1 commit into from

Conversation

@aanm
Copy link

@aanm aanm commented Jan 8, 2021 •
edited
Loading

/kind dependency-change
/kind feature

What this PR does / why we need it:\

This commit adds the ability to run cri-o with new capabilities
available in the linux kernel:

CAP_PERFMON
CAP_BPF
CAP_CHECKPOINT_RESTORE

Add ability to have `CAP_PERFMON`, `CAP_BPF` and `CAP_CHECKPOINT_RESTORE` capabilities in supported kernels.

@aanm aanm requested review from mrunalp and runcom as code owners January 8, 2021 18:19
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2021

Hi @aanm. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

haircommander commented Jan 8, 2021

/ok-to-test
/approve

thanks for the PR @aanm , I only have one nit: can you change the PR description to cri-o, not containerd :)

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021 •
edited
Loading

Codecov Report

Merging #4463 (ce31068) into main (6517447) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4463      +/-   ##
==========================================
+ Coverage   40.09%   40.11%   +0.02%     
==========================================
  Files         116      116              
  Lines        9378     9378              
==========================================
+ Hits         3760     3762       +2     
+ Misses       5212     5211       -1     
+ Partials      406      405       -1

@aanm
vendor: update syndtr/gocapability
ce31068 
This commit adds the ability to run cri-o with new capabilities
available in the linux kernel:

CAP_PERFMON
CAP_BPF
CAP_CHECKPOINT_RESTORE

Signed-off-by: André Martins <[email protected]>
@aanm aanm force-pushed the pr/add-capabilities branch from b1dec11 to ce31068 Compare January 8, 2021 20:49
@aanm
Copy link
Author

aanm commented Jan 8, 2021

/ok-to-test
/approve

thanks for the PR @aanm , I only have one nit: can you change the PR description to cri-o, not containerd :)

@haircommander ups, sorry about that 😅 done!

@haircommander
Copy link
Member

haircommander commented Jan 8, 2021

no problem at all 😄

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@aanm
Copy link
Author

aanm commented Jan 8, 2021

@haircommander is the CI failing because of runc. I can see that runc hasn't made a release with the following change opencontainers/runc@6dfbe9b80707 so the packets installed with dnf in the CI might not have this change.

@haircommander
Copy link
Member

haircommander commented Jan 8, 2021

hm we should be building off of main runc branch for everything except the pipeline tests and the ci/prow tests. and it seems integration_Cgroup_v2 is a flake (for this run at least)

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aanm, haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member

haircommander commented Jan 11, 2021

/retest

@haircommander
Copy link
Member

haircommander commented Jan 11, 2021

/hold

sorry @aanm , I think we need to hold this until runc bumps (our CI uses master, but upstream k8s CI uses a pinned version) ref: #4467

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@aanm
Copy link
Author

aanm commented Jan 11, 2021

@haircommander do you know anyone from runc to make a new release? I can see the last version was last August so it would probably make sense to create a new one I say.

@haircommander
Copy link
Member

haircommander commented Jan 11, 2021

I do! @kolyshkin and @mrunalp are both maintainers. I thought there was an issue around v1.0.0-rc93 but I can't find it

@haircommander
Copy link
Member

haircommander commented Jan 11, 2021

ah, you can track progress here https://github.com/opencontainers/runc/milestone/10

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 12, 2021

@aanm: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2021
@aanm aanm mentioned this pull request Jan 12, 2021
Closed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@aanm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic ce31068 link /test e2e-agnostic
ci/prow/images ce31068 link /test images
ci/prow/e2e-gcp ce31068 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aanm
Copy link
Author

aanm commented Feb 18, 2022

Fixed in #5241

@aanm aanm closed this Feb 18, 2022
@aanm aanm deleted the pr/add-capabilities branch February 18, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

@nalind nalind Awaiting requested review from nalind

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aanm @openshift-ci-robot @haircommander @mrunalp @saschagrunert