Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mrunalp
Copy link
Member

@mrunalp mrunalp commented Apr 13, 2017

@runcom @sameo @cyphar @rhatdan PTAL

Signed-off-by: Mrunal Patel [email protected]

Signed-off-by: Mrunal Patel <[email protected]>
@runcom
Copy link
Member

runcom commented Apr 13, 2017

LGTM 👍

@cyphar
Copy link
Contributor

cyphar commented Apr 13, 2017

LGTM

@cyphar
Copy link
Contributor

cyphar commented Apr 13, 2017

Would you be interested in something like umoci's release.sh script (which generates signed git archives, ready for uploading to GitHub so distributions can pull signed archives).

@mrunalp
Copy link
Member Author

mrunalp commented Apr 13, 2017

@cyphar Yes, that will be great.

@cyphar
Copy link
Contributor

cyphar commented Apr 13, 2017

Alright, I'll modify my script for cri-o.

@runcom runcom merged commit 7d7570e into cri-o:master Apr 13, 2017
@mrunalp
Copy link
Member Author

mrunalp commented Apr 13, 2017

@cyphar I will cut the release. Can you upload the binaries to it with your script?

@cyphar
Copy link
Contributor

cyphar commented Apr 13, 2017

Sure. I'll upload the binaries and also the signed archive. I'll also make a PR with the required patches to make release.sh nice. Unfortunately you can't statically compile ocid. 😢

@mrunalp
Copy link
Member Author

mrunalp commented Apr 13, 2017

@cyphar Will leave it in your hands then https://github.com/kubernetes-incubator/cri-o/releases/tag/v0.2 :)
Let me know once you are done uploading. I will send out email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants