server: add auth info to image pull #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
sameo
reviewed
Apr 10, 2017
| DockerAuthConfig: &types.DockerAuthConfig{ | ||
| Username: username, | ||
| Password: password, | ||
| }, |
There was a problem hiding this comment.
I assume this will be a NOOP when username and password are nil ?
Member
Author
There was a problem hiding this comment.
not actually, I re-pushed a fixed version I guess. If those are empty, we'll simply not read the .docker/config.json. The latest revision makes sure not to send anything if password is empty.
71da71a to
c3360b6
Compare
sameo
reviewed
Apr 10, 2017
server/image_pull.go
Outdated
| options := ©.Options{} | ||
| // a not empty password should be sufficient to decide whether to send auth | ||
| // or not I guess | ||
| if password != "" { |
There was a problem hiding this comment.
Although I can see people using password less accounts, I really don't know how they could have username less ones. So I'd use username not being empty as a criteria to send auth, instead of password.
Fix the following upstream k8s's e2e-node test: ``` should be able to pull from private registry with secret [Conformance] ``` Signed-off-by: Antonio Murdaca <[email protected]>
c3360b6 to
05cde3e
Compare
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
|
@sarahnovotny @yujuhong Can we get @sameo setup with commit access to the repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following upstream k8s's e2e-node test:
Signed-off-by: Antonio Murdaca [email protected]