convert shmsize annotation to handler_allowed #4402

wgahnagl · 2020-12-02T15:36:12Z

What type of PR is this?

/kind api-change
/kind bug
/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake
/kind other

What this PR does / why we need it:

allows the shmsize to be set with a handler allowed annotation

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Moves shm size to a handler-allowed annotation

openshift-ci-robot · 2020-12-02T15:36:21Z

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-12-02T15:38:29Z

@dkatipamula this is the behavior change btw

codecov · 2020-12-02T16:06:45Z

Codecov Report

Merging #4402 (a4588db) into master (5e58378) will increase coverage by 0.02%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #4402      +/-   ##
==========================================
+ Coverage   40.49%   40.52%   +0.02%     
==========================================
  Files         116      116              
  Lines        9329     9326       -3     
==========================================
+ Hits         3778     3779       +1     
+ Misses       5125     5120       -5     
- Partials      426      427       +1

haircommander · 2020-12-02T16:17:37Z

/ok-to-test

haircommander · 2020-12-02T17:17:04Z

we will need a release note on this btw explaining the dropped config value and the new usage
/retest

umohnani8 · 2020-12-02T20:27:36Z

Changes LGTM
@wgahnagl can you please add a release note.

test/shm_size.bats

kolyshkin · 2020-12-03T04:49:38Z

test/shm_size.bats

+runtime_path = "$RUNTIME_BINARY"
+runtime_root = "$RUNTIME_ROOT"
+runtime_type = "$RUNTIME_TYPE"
+allowed_annotations = ["io.kubernetes.cri-o.ShmSize"]


Can allowed_annotations be specified on a global (rather than per-runtime) basis? The way it is configured now kinda overloads the meaning of a runtime.

not currently!

completions/fish/crio.fish

pkg/config/template.go

docs/crio.conf.5.md

pkg/config/config.go

haircommander · 2020-12-07T21:01:58Z

/cherry-pick release-1.20

openshift-cherrypick-robot · 2020-12-07T21:01:59Z

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-12-07T21:37:01Z

/retest
/approve

LGTM @umohnani8 @mrunalp @kolyshkin PTAL

openshift-ci-robot · 2020-12-07T21:37:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrunalp · 2020-12-07T21:57:14Z

/lgtm

umohnani8 · 2020-12-07T21:58:40Z

LGTM

haircommander · 2020-12-08T02:26:11Z

/retest

haircommander · 2020-12-08T14:21:05Z

/retest

Signed-off-by: Skyler Clark <[email protected]>

haircommander · 2020-12-08T14:31:34Z

/lgtm

(needed another docs update)

haircommander · 2020-12-08T18:24:28Z

/retest

openshift-cherrypick-robot · 2020-12-08T20:11:05Z

@haircommander: new pull request created: #4417

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wgahnagl requested review from mrunalp and runcom as code owners December 2, 2020 15:36

openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Dec 2, 2020

openshift-ci-robot requested a review from sameo December 2, 2020 15:36

openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2020

wgahnagl changed the title ~~Shmsize annotation~~ convert shmsize annotation to handler_allowed Dec 2, 2020

wgahnagl force-pushed the shmsize-annotation branch from 54b5da6 to 4867c83 Compare December 2, 2020 15:37

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Dec 2, 2020

wgahnagl changed the title ~~convert shmsize annotation to handler_allowed~~ [WIP] convert shmsize annotation to handler_allowed Dec 2, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020

wgahnagl force-pushed the shmsize-annotation branch from 4867c83 to e838c8e Compare December 2, 2020 15:38

wgahnagl force-pushed the shmsize-annotation branch 2 times, most recently from a721d78 to 7526a12 Compare December 2, 2020 15:54

wgahnagl changed the title ~~[WIP] convert shmsize annotation to handler_allowed~~ convert shmsize annotation to handler_allowed Dec 2, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2020

haircommander added this to the 1.20 milestone Dec 2, 2020

kolyshkin reviewed Dec 3, 2020

View reviewed changes

test/shm_size.bats Outdated Show resolved Hide resolved

kolyshkin reviewed Dec 3, 2020

View reviewed changes

test/shm_size.bats Show resolved Hide resolved

kolyshkin reviewed Dec 3, 2020

View reviewed changes

haircommander reviewed Dec 7, 2020

View reviewed changes

completions/fish/crio.fish Outdated Show resolved Hide resolved

wgahnagl force-pushed the shmsize-annotation branch from 5f60307 to 2444fe6 Compare December 7, 2020 20:08

haircommander reviewed Dec 7, 2020

View reviewed changes

pkg/config/template.go Outdated Show resolved Hide resolved

wgahnagl force-pushed the shmsize-annotation branch from 2444fe6 to 2727368 Compare December 7, 2020 20:41

haircommander reviewed Dec 7, 2020

View reviewed changes

docs/crio.conf.5.md Outdated Show resolved Hide resolved

haircommander reviewed Dec 7, 2020

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

wgahnagl force-pushed the shmsize-annotation branch from 2727368 to 68bdf58 Compare December 7, 2020 21:16

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020

openshift-ci-robot assigned mrunalp Dec 7, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020

moves shmsize to a handler allowed annotation

a4588db

Signed-off-by: Skyler Clark <[email protected]>

wgahnagl force-pushed the shmsize-annotation branch from 68bdf58 to a4588db Compare December 8, 2020 14:29

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020

openshift-ci-robot assigned haircommander Dec 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020

openshift-merge-robot merged commit a55de72 into cri-o:master Dec 8, 2020

openshift-cherrypick-robot mentioned this pull request Dec 8, 2020

[release-1.20] convert shmsize annotation to handler_allowed #4417

Merged

wgahnagl deleted the shmsize-annotation branch December 14, 2020 15:14

wgahnagl mentioned this pull request Feb 15, 2022

REQUEST: New membership for wgahnagl #5649

Closed

4 tasks

convert shmsize annotation to handler_allowed #4402

convert shmsize annotation to handler_allowed #4402

Uh oh!

Conversation

wgahnagl commented Dec 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Dec 2, 2020

Uh oh!

haircommander commented Dec 2, 2020

Uh oh!

codecov bot commented Dec 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

haircommander commented Dec 2, 2020

Uh oh!

haircommander commented Dec 2, 2020

Uh oh!

umohnani8 commented Dec 2, 2020

Uh oh!

Uh oh!

Uh oh!

kolyshkin Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

haircommander Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haircommander commented Dec 7, 2020

Uh oh!

openshift-cherrypick-robot commented Dec 7, 2020

Uh oh!

haircommander commented Dec 7, 2020

Uh oh!

openshift-ci-robot commented Dec 7, 2020

Uh oh!

mrunalp commented Dec 7, 2020

Uh oh!

umohnani8 commented Dec 7, 2020

Uh oh!

haircommander commented Dec 8, 2020

Uh oh!

haircommander commented Dec 8, 2020

Uh oh!

haircommander commented Dec 8, 2020

Uh oh!

haircommander commented Dec 8, 2020

Uh oh!

openshift-cherrypick-robot commented Dec 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

wgahnagl commented Dec 2, 2020 •

edited

Loading

codecov bot commented Dec 2, 2020 •

edited

Loading