Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: use IsAlive() more #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 15, 2021
Merged

server: use IsAlive() more #4406

openshift-merge-robot merged 1 commit into from
Jan 15, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Dec 3, 2020 •
edited
Loading

What type of PR is this?

/kind api-change
/kind bug
/kind ci

/kind cleanup

/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

this replaces unneeded State() and UpdateContainerResources() calls,
which both saves on lock contention, as well as possibly saves on a call to runc state

Signed-off-by: Peter Hunt [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

replaces #3864

Does this PR introduce a user-facing change?

none

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@haircommander haircommander mentioned this pull request Dec 3, 2020
Closed
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2020
saschagrunert
saschagrunert approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giuseppe
giuseppe approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Dec 4, 2020

LGTM
assuming happy tests

@haircommander
Copy link
Member Author

haircommander commented Dec 4, 2020

LGTM
assuming happy tests

happy tests? you ask for too much

@mrunalp
Copy link
Member

mrunalp commented Dec 7, 2020

Do these changes play well with kata?

@codecov
Copy link

codecov bot commented Dec 7, 2020 •
edited
Loading

Codecov Report

Merging #4406 (0aeb7d2) into master (6ee8d68) will increase coverage by 0.04%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master    #4406      +/-   ##
==========================================
+ Coverage   40.09%   40.13%   +0.04%     
==========================================
  Files         116      116              
  Lines        9378     9365      -13     
==========================================
- Hits         3760     3759       -1     
+ Misses       5212     5200      -12     
  Partials      406      406

@haircommander
Copy link
Member Author

haircommander commented Dec 7, 2020

I believe they should, as we still set a InitPid for the container, even for shim v2. @fidencio can you ptal?

@fidencio
Copy link
Contributor

fidencio commented Dec 7, 2020

Added to my list, will test it soon, please, don't merge it before I get back to this one.

@haircommander
Copy link
Member Author

haircommander commented Dec 7, 2020

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2020
@fidencio
Copy link
Contributor

fidencio commented Dec 14, 2020

I know the patch needs rebase but I finally got an environment where I could test it as it is.
The basic CI on kata passed without any issues. Knowing this, we're good to go after the rebase is done.

And sorry for the delay here.

@fidencio
Copy link
Contributor

fidencio commented Dec 14, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2020
@haircommander
server: use IsAlive() more
0aeb7d2 
this replaces unneeded State() and UpdateContainerResources() calls,
which both saves on lock contention, as well as possibly saves on a call to `runc state`

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2020
@fidencio
Copy link
Contributor

fidencio commented Dec 14, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2020
@fidencio
Copy link
Contributor

fidencio commented Dec 14, 2020

/retest

4 similar comments
@fidencio
Copy link
Contributor

fidencio commented Dec 14, 2020

/retest

@fidencio
Copy link
Contributor

fidencio commented Dec 14, 2020

/retest

@haircommander
Copy link
Member Author

haircommander commented Dec 15, 2020

/retest

@haircommander
Copy link
Member Author

haircommander commented Dec 15, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 15, 2020

@haircommander: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 0aeb7d2 link /test e2e-gcp
ci/prow/e2e-agnostic 0aeb7d2 link /test e2e-agnostic

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

haircommander commented Jan 5, 2021

/retest

7 similar comments
@haircommander
Copy link
Member Author

haircommander commented Jan 5, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Jan 6, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Jan 8, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Jan 8, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Jan 8, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Jan 14, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Jan 15, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2021

@haircommander: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 0aeb7d2 link /test e2e-gcp
ci/prow/e2e-agnostic 0aeb7d2 link /test e2e-agnostic

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6a885a4 into cri-o:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe giuseppe approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@nalind nalind Awaiting requested review from nalind

@sameo sameo Awaiting requested review from sameo

Assignees

@fidencio fidencio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@haircommander @openshift-ci-robot @TomSweeneyRedHat @mrunalp @fidencio @openshift-merge-robot @giuseppe @saschagrunert