contrib/test/int: assorted minor cleanups #4419

kolyshkin · 2020-12-08T21:18:43Z

What type of PR is this?

/kind ci

What this PR does / why we need it:

Assorted fixes and cleanups to contrib/test/integration.

Please see individual commits for details.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

This separation (to skip a single test under RHEL/CentOS) and the associated TODO/XXX were added in 2017, and the issue linked is fixed in mid-2018. Time to address the TODO ;) Signed-off-by: Kir Kolyshkin <[email protected]>

Modern critest complains: > Using "/var/run/crio/crio.sock" as endpoint is deprecated, > please consider using full url format "unix:///var/run/crio/crio.sock" and this pollutes test logs. Add unix:// prefix where appropriate. Signed-off-by: Kir Kolyshkin <[email protected]>

This is the same change as in commit a400561; quoting it: Also, the masquerading rule (needed for critest) was changed to use 127.0.0.0/8 network rather than 127.0.0.1 address, because systemd-resolved is listening at 127.0.0.53 address, and indeed the whole 127.0.0.0/8 block is reserved for local addresses. This is merely to future-proof the configuration so it will work with systemd-resolved. Signed-off-by: Kir Kolyshkin <[email protected]>

This appears unused by the current CI, and I was not able to find the traces of it being used. In addition, the CONTAINER_RUNTIME_ENDPOINT=unix:///var/run/crio.sock does not look correct. Signed-off-by: Kir Kolyshkin <[email protected]>

mrunalp · 2020-12-08T22:18:29Z

/lgtm

codecov · 2020-12-08T22:53:14Z

Codecov Report

Merging #4419 (6d42e8b) into master (a55de72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4419   +/-   ##
=======================================
  Coverage   40.52%   40.52%           
=======================================
  Files         116      116           
  Lines        9327     9327           
=======================================
  Hits         3780     3780           
  Misses       5120     5120           
  Partials      427      427

kolyshkin · 2020-12-09T02:09:06Z

Failures in circleci (in docs-generation and completions-validation) do not make any sense; restarted

kolyshkin · 2020-12-09T03:43:04Z

@haircommander there is a failure in integration_rhel+userns (see https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-federated-results/pr-logs/pull/cri-o_cri-o/4419/test_pull_request_crio_integration_rhel/21891/artifacts/testout_userns.txt)

not ok 182 should not clean up container after timeout
(in test file ./timeout.bats, line 69)
`created_ctr_id=$("$CONTAINER_RUNTIME" --root "$RUNTIME_ROOT" list -q | grep -v "$pod_id")' failed
time="2020-12-09T02:02:14Z" level=fatal msg="creating container: rpc error: code = DeadlineExceeded desc = context deadline exceeded"

The test case is from #4394; but this branch does not have it. I guess CI is testing commits from this PR applied on top of latest master.

Anyway, my guess is 2s is too low for our slow and highly parallel CI.

kolyshkin · 2020-12-09T04:05:28Z

there is a failure in integration_rhel+userns

Trying to address that in #4422

/retest

saschagrunert

LGTM

saschagrunert · 2020-12-09T07:18:43Z

/retest

openshift-merge-robot · 2020-12-09T07:28:03Z

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic	`6d42e8b`	link	`/test e2e-agnostic`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

haircommander · 2021-01-05T20:58:32Z

/retest

mrunalp · 2021-01-13T04:33:56Z

/lgtm

saschagrunert

/lgtm
/retest

openshift-ci-robot · 2021-01-13T08:18:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kolyshkin,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2021-01-13T16:08:07Z

/retest

saschagrunert · 2021-01-18T07:32:43Z

/retest

haircommander · 2021-03-04T16:01:46Z

/retest

haircommander · 2021-03-04T17:00:54Z

/override ci/openshift-jenkins/integration_crun

openshift-ci-robot · 2021-03-04T17:01:10Z

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

Details

In response to this:

/override ci/openshift-jenkins/integration_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2021-03-04T17:02:14Z

/test integration_crun

openshift-ci-robot · 2021-03-04T17:26:08Z

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/kata-jenkins	`6d42e8b`	link	`/test kata-containers`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

haircommander · 2021-03-04T17:41:59Z

/override ci/kata-jenkins

openshift-ci-robot · 2021-03-04T17:42:11Z

@haircommander: Overrode contexts on behalf of haircommander: ci/kata-jenkins

Details

In response to this:

/override ci/kata-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-03-04T17:42:54Z

@kolyshkin: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic	`6d42e8b`	link	`/test e2e-agnostic`
ci/openshift-jenkins/integration_crun_cgroupv2	`6d42e8b`	link	`/test integration_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kolyshkin added 4 commits December 8, 2020 12:48

critest.yml: don't skip test on RHEL

2f073ad

This separation (to skip a single test under RHEL/CentOS) and the associated TODO/XXX were added in 2017, and the issue linked is fixed in mid-2018. Time to address the TODO ;) Signed-off-by: Kir Kolyshkin <[email protected]>

contrib/test/int: rm node-e2e test

6d42e8b

This appears unused by the current CI, and I was not able to find the traces of it being used. In addition, the CONTAINER_RUNTIME_ENDPOINT=unix:///var/run/crio.sock does not look correct. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin requested review from mrunalp and runcom as code owners December 8, 2020 21:18

openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 8, 2020

openshift-ci-robot requested a review from vrothberg December 8, 2020 21:18

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020

mrunalp approved these changes Dec 8, 2020

View reviewed changes

openshift-ci-robot assigned mrunalp Dec 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020

saschagrunert approved these changes Dec 9, 2020

View reviewed changes

mrunalp approved these changes Jan 13, 2021

View reviewed changes

saschagrunert approved these changes Jan 13, 2021

View reviewed changes

openshift-ci-robot assigned saschagrunert Jan 13, 2021

openshift-merge-robot merged commit 791c7f2 into cri-o:master Mar 4, 2021

contrib/test/int: assorted minor cleanups #4419

contrib/test/int: assorted minor cleanups #4419

Uh oh!

Conversation

kolyshkin commented Dec 8, 2020

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

mrunalp commented Dec 8, 2020

Uh oh!

codecov bot commented Dec 8, 2020

Codecov Report

Uh oh!

kolyshkin commented Dec 9, 2020

Uh oh!

kolyshkin commented Dec 9, 2020

Uh oh!

kolyshkin commented Dec 9, 2020

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

saschagrunert commented Dec 9, 2020

Uh oh!

openshift-merge-robot commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haircommander commented Jan 5, 2021

Uh oh!

mrunalp commented Jan 13, 2021

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 13, 2021

Uh oh!

haircommander commented Jan 13, 2021

Uh oh!

saschagrunert commented Jan 18, 2021

Uh oh!

haircommander commented Mar 4, 2021

Uh oh!

haircommander commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

haircommander commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

haircommander commented Mar 4, 2021

Uh oh!

openshift-ci-robot commented Mar 4, 2021

Uh oh!

openshift-ci bot commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-merge-robot commented Dec 9, 2020 •

edited

Loading