[release-1.20] test/ctr.bats: fix a "ctr execsync" flake #4427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case is sometimes fails like this: > not ok 40 ctr execsync > # (in test file ./ctr.bats, line 429) > # `[[ "$output" == *"command timed out"* ]]' failed > ..... > # time="2020-12-02T23:28:58Z" level=fatal msg="connect: connect endpoint 'unix:///tmp/tmp.ncaFI2tZzn/crio.sock', make sure you are running as root and the endpoint has been started: context deadline exceeded" This happens because our CI might be slow and this 1 second timeout also applies to connect. Increase the timeout and the sleep accordingly to fix the flake. Signed-off-by: Kir Kolyshkin <[email protected]>
Member
|
/approve |
Codecov Report
@@ Coverage Diff @@
## release-1.20 #4427 +/- ##
=============================================
Coverage 40.52% 40.52%
=============================================
Files 116 116
Lines 9327 9327
=============================================
Hits 3780 3780
Misses 5120 5120
Partials 427 427 |
Member
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
1 similar comment
Member
|
/retest |
Member
|
kata failures are unrelated, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4411
/assign haircommander