Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mrunalp
Copy link
Member

@mrunalp mrunalp commented Feb 5, 2021

This reverts commit 8164338 (PR #4539).

https://bugzilla.redhat.com/show_bug.cgi?id=1925623

Signed-off-by: Mrunal Patel [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Revert systemd KillMode to control-group (default)

@mrunalp mrunalp requested a review from runcom as a code owner February 5, 2021 18:09
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 5, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #4547 (2c9c713) into release-1.20 (2ef6415) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.20    #4547      +/-   ##
================================================
- Coverage         40.62%   40.60%   -0.02%     
================================================
  Files               117      117              
  Lines              9450     9446       -4     
================================================
- Hits               3839     3836       -3     
+ Misses             5178     5177       -1     
  Partials            433      433              

@mrunalp
Copy link
Member Author

mrunalp commented Feb 5, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 5, 2021
@mrunalp
Copy link
Member Author

mrunalp commented Feb 5, 2021

/test e2e-aws

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kolyshkin,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/retest

@haircommander
Copy link
Member

we're waiting on one possible avenue before removing this hold

@mrunalp
Copy link
Member Author

mrunalp commented Feb 8, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@haircommander
Copy link
Member

/retest

@openshift-cherrypick-robot

@haircommander: new pull request could not be created: failed to create pull request against cri-o/cri-o#master from head openshift-cherrypick-robot:cherry-pick-4547-to-master: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between cri-o:master and openshift-cherrypick-robot:cherry-pick-4547-to-master"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants