-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[1.20] Revert "Set systemd property KillMode to mixed for containers" #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20] Revert "Set systemd property KillMode to mixed for containers" #4547
Conversation
This reverts commit 8164338. Signed-off-by: Mrunal Patel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.20 #4547 +/- ##
================================================
- Coverage 40.62% 40.60% -0.02%
================================================
Files 117 117
Lines 9450 9446 -4
================================================
- Hits 3839 3836 -3
+ Misses 5178 5177 -1
Partials 433 433 |
|
/hold |
kolyshkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/test e2e-aws |
saschagrunert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
we're waiting on one possible avenue before removing this hold |
|
/hold cancel |
|
/retest |
|
@haircommander: new pull request could not be created: failed to create pull request against cri-o/cri-o#master from head openshift-cherrypick-robot:cherry-pick-4547-to-master: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between cri-o:master and openshift-cherrypick-robot:cherry-pick-4547-to-master"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit 8164338 (PR #4539).
https://bugzilla.redhat.com/show_bug.cgi?id=1925623
Signed-off-by: Mrunal Patel [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?