Add arm64 static build to GitHub actions and bundle #4552

saschagrunert · 2021-02-08T15:05:33Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds a new derivation to build statically linked binaries for
arm64.

Which issue(s) this PR fixes:

Refers to #4551

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added arm64 variant to static binary bundle. The bundle is now available via the URL
`https://storage.googleapis.com/k8s-conform-cri-o/artifacts/cri-o.$ARCH.$VERSION.tar.gz`,
where `$ARCH` can be `amd64` or `arm64` and `$VERSION` a tag or full length git SHA.
Beside that, we provide a new installation script
`curl https://raw.githubusercontent.com/cri-o/cri-o/master/scripts/get | bash`.
For this script, it is also possible to pass the architecture and version as arguments:
`get [amd64|arm64] [VERSION|SHA]`.
The static binary bundle now uses crun as default container runtime for CRI-O.

openshift-ci-robot · 2021-02-08T15:05:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saschagrunert · 2021-02-08T15:16:58Z

Works ✔️

There is a slack conversation ongoing where we could do some manual external testing: https://kubernetes.slack.com/archives/CAZH62UR1/p1612626775090600

/hold

codecov · 2021-02-08T15:47:47Z

Codecov Report

Merging #4552 (65d2410) into master (8d2de74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4552   +/-   ##
=======================================
  Coverage   40.53%   40.53%           
=======================================
  Files         115      115           
  Lines        9442     9442           
=======================================
  Hits         3827     3827           
  Misses       5182     5182           
  Partials      433      433

saschagrunert · 2021-02-18T10:41:12Z

I have to update the PR once crun 0.18 is available: containers/crun#604

saschagrunert · 2021-02-18T13:03:09Z

/retest

TomSweeneyRedHat · 2021-02-18T14:55:34Z

LGTM
assuming happy tests

openshift-ci-robot · 2021-02-19T09:01:58Z

@harche: GitHub didn't allow me to request PR reviews from the following users: odinuge.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Cool.

/cc @odinuge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2021-02-19T09:09:05Z

README.md


 ```shell
-> curl -f https://storage.googleapis.com/k8s-conform-cri-o/artifacts/crio-$(git ls-remote https://github.com/cri-o/cri-o master | cut -c1-9).tar.gz -o crio.tar.gz
+> curl https://raw.githubusercontent.com/cri-o/cri-o/master/get | bash


The url mentioned in #4587 (comment) is still valid right? Because that's what I am using in kubernetes/test-infra#20898

Would it be a good idea to have a complete URL, say as an example only for amd64, mentioned here? Just for someone who might not want to pipe a script from web into bash or someone like me who end up using complete URL in a systemd service file.

Yes, that still applies. I changed the README.md to mention that URL path, too. But we have to be aware that this could cause a race (CI not finished or failed) in comparison to the script which will always succeed.

Oh, ok, then in my case, I will change the systemd service file to first download the script and execute it locally.

Yeah, this is way more safe and decouples our CI from the consumer of the script.

Thanks. I was wondering, if it's possible to keep the old url around for sometime. It would take me sometime to get this tested and added in test-infra. Until then the periodic job, will keep failing :(

Just checking if it's possible, hate to see the prow dashboard in red :)

I really like this approach @saschagrunert! The old one was kinda fragile, so thanks!

harche

Looks cool @saschagrunert. Just a couple of queries, but otherwise LGTM. :)

saschagrunert · 2021-02-19T09:53:24Z

Looks cool @saschagrunert. Just a couple of queries, but otherwise LGTM. :)

Thank you! Please also note:

The static binary bundle now uses crun as default container runtime for CRI-O.

odinuge · 2021-02-19T09:56:18Z

get

+#!/usr/bin/env bash
+set -euo pipefail
+
+ARCH=${1:-amd64}


It would be nice to just default to empty, and use uname to detec the correct arch.

$ uname -m #x86 x86_64 $ uname -m #arm64 aarch64

I reworked the script to now accept parsed CLI arguments as well as a help output. We now fallback to uname -m (converted to amd64/arm64), too. :)

Awesome!! 😄

get

odinuge · 2021-02-19T09:58:27Z

README.md


 ```shell
-> curl -f https://storage.googleapis.com/k8s-conform-cri-o/artifacts/crio-$(git ls-remote https://github.com/cri-o/cri-o master | cut -c1-9).tar.gz -o crio.tar.gz
+> curl https://raw.githubusercontent.com/cri-o/cri-o/master/get | bash


I really like this approach @saschagrunert! The old one was kinda fragile, so thanks!

saschagrunert · 2021-02-19T11:21:19Z

/test kata-containers

saschagrunert · 2021-03-01T08:03:31Z

@haircommander do you think we can get this one in?

haircommander · 2021-03-01T14:37:31Z

/lgtm

haircommander · 2021-03-01T14:40:55Z

I know I just gave this lgtm, but I've realized I'm hesitant to introduce a script to the top level of the tree

/lgtm cancel

can we move it to the scripts/ directory? or is there a reason to keep it top-level?

This adds a new derivation to build statically linked binaries for arm64. Signed-off-by: Sascha Grunert <[email protected]>

saschagrunert · 2021-03-01T14:42:29Z

can we move it to the scripts/ directory? or is there a reason to keep it top-level?

Yes sure, moved the script into the scripts directory. 👍

haircommander · 2021-03-01T14:44:07Z

/lgtm

thanks @saschagrunert 😃

saschagrunert · 2021-03-01T14:47:57Z

/test integration_fedora

saschagrunert · 2021-03-01T15:17:12Z

/test integration_fedora

saschagrunert · 2021-03-01T16:06:01Z

/test integration_fedora

openshift-ci · 2021-03-01T17:12:50Z

@saschagrunert: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic	`4ff8662`	link	`/test e2e-agnostic`
ci/openshift-jenkins/integration_crun_cgroupv2	`4ff8662`	link	`/test integration_cgroupv2`
ci/prow/e2e-gcp	`4ff8662`	link	`/test e2e-gcp`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

saschagrunert · 2021-03-01T19:17:16Z

/test kata-containers

saschagrunert requested review from mrunalp and runcom as code owners February 8, 2021 15:05

openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 8, 2021

openshift-ci-robot requested a review from nalind February 8, 2021 15:05

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021

saschagrunert mentioned this pull request Feb 8, 2021

Support for arm 64bit static binary bundles. #4551

Closed

3 tasks

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021

saschagrunert force-pushed the arm-static branch from 9795629 to 54af5ad Compare February 9, 2021 09:08

saschagrunert mentioned this pull request Feb 9, 2021

Add arm64 static build binary containers/conmon#239

Merged

saschagrunert force-pushed the arm-static branch from 54af5ad to bbe11d0 Compare February 18, 2021 10:22

saschagrunert mentioned this pull request Feb 18, 2021

Use the full sha value to name the bundle file #4587

Closed

saschagrunert force-pushed the arm-static branch from bbe11d0 to 2efc0b3 Compare February 18, 2021 10:30

saschagrunert changed the title ~~Add arm64 static build to GitHub actions~~ Add arm64 static build to GitHub actions and bundle Feb 18, 2021

saschagrunert force-pushed the arm-static branch from 2efc0b3 to 8378738 Compare February 18, 2021 11:14

harche mentioned this pull request Feb 18, 2021

WIP: Download crio using updated bundle filename kubernetes/test-infra#20898

Closed

saschagrunert force-pushed the arm-static branch from 8378738 to aaf1e21 Compare February 18, 2021 12:15

saschagrunert force-pushed the arm-static branch 5 times, most recently from 2037067 to 58014de Compare February 18, 2021 14:11

saschagrunert force-pushed the arm-static branch from 58014de to 03bc5a5 Compare February 18, 2021 15:23

harche reviewed Feb 19, 2021

View reviewed changes

saschagrunert force-pushed the arm-static branch from 53e69a2 to 5cc86ab Compare February 19, 2021 09:27

saschagrunert mentioned this pull request Feb 19, 2021

Add support for recording profiles of multiple containers in a single pod kubernetes-sigs/security-profiles-operator#324

Closed

odinuge reviewed Feb 19, 2021

View reviewed changes

saschagrunert force-pushed the arm-static branch 3 times, most recently from 668c772 to d6f6b5a Compare February 19, 2021 10:42

openshift-ci-robot assigned haircommander Mar 1, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021

Add arm64 static build to GitHub actions

4ff8662

This adds a new derivation to build statically linked binaries for arm64. Signed-off-by: Sascha Grunert <[email protected]>

saschagrunert force-pushed the arm-static branch from d6f6b5a to 4ff8662 Compare March 1, 2021 14:42

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021

openshift-merge-robot merged commit c49f180 into cri-o:master Mar 1, 2021

saschagrunert deleted the arm-static branch March 1, 2021 19:51

kolyshkin mentioned this pull request Sep 15, 2021

ci: bump crun to 0.16; test crun with selinux #4392

Closed

Add arm64 static build to GitHub actions and bundle #4552

Add arm64 static build to GitHub actions and bundle #4552

Uh oh!

Conversation

saschagrunert commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Feb 8, 2021

Uh oh!

saschagrunert commented Feb 8, 2021

Uh oh!

codecov bot commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

saschagrunert commented Feb 18, 2021

Uh oh!

saschagrunert commented Feb 18, 2021

Uh oh!

TomSweeneyRedHat commented Feb 18, 2021

Uh oh!

openshift-ci-robot commented Feb 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harche Feb 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harche left a comment

Choose a reason for hiding this comment

Uh oh!

saschagrunert commented Feb 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saschagrunert commented Feb 19, 2021

Uh oh!

saschagrunert commented Mar 1, 2021

Uh oh!

haircommander commented Mar 1, 2021

Uh oh!

haircommander commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saschagrunert commented Mar 1, 2021

Uh oh!

haircommander commented Mar 1, 2021

Uh oh!

saschagrunert commented Mar 1, 2021

Uh oh!

saschagrunert commented Mar 1, 2021

Uh oh!

saschagrunert commented Mar 1, 2021

Uh oh!

openshift-ci bot commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saschagrunert commented Mar 1, 2021

Uh oh!

saschagrunert commented Feb 8, 2021 •

edited

Loading

codecov bot commented Feb 8, 2021 •

edited

Loading

harche Feb 19, 2021 •

edited

Loading

haircommander commented Mar 1, 2021 •

edited

Loading

openshift-ci bot commented Mar 1, 2021 •

edited

Loading