Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.20] Log container stop timeout #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 9, 2021
Merged

[1.20] Log container stop timeout #4554

openshift-merge-robot merged 1 commit into from
Feb 9, 2021

Conversation

@mrunalp
Copy link
Member

@mrunalp mrunalp commented Feb 8, 2021

Signed-off-by: Mrunal Patel [email protected]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Logs the container stop timeout so it is always visible at the info level.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Log the container stop timeout at default log level

@mrunalp
Log container stop timeout
37a8420 
Signed-off-by: Mrunal Patel <[email protected]>
@mrunalp mrunalp requested a review from runcom as a code owner February 8, 2021 19:44
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #4554 (37a8420) into release-1.20 (c15ec58) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@               Coverage Diff                @@
##           release-1.20    #4554      +/-   ##
================================================
- Coverage         40.64%   40.62%   -0.02%     
================================================
  Files               117      117              
  Lines              9453     9449       -4     
================================================
- Hits               3842     3839       -3     
+ Misses             5178     5177       -1     
  Partials            433      433

saschagrunert
saschagrunert approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haircommander
Copy link
Member

haircommander commented Feb 9, 2021

/lgtm

/cherry-pick master

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 9, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

Details

In response to this:

/lgtm

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
kolyshkin
kolyshkin approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kolyshkin,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fdbdf43 into cri-o:release-1.20 Feb 9, 2021
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 9, 2021

@haircommander: #4554 failed to apply on top of branch "master":

Applying: Log container stop timeout
Using index info to reconstruct a base tree...
M	server/container_stop.go
Falling back to patching base and 3-way merge...
Auto-merging server/container_stop.go
CONFLICT (content): Merge conflict in server/container_stop.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Log container stop timeout
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/lgtm

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander haircommander added the needs-forwardport This PR should be also added to every version that comes after label Feb 10, 2021
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 10, 2021

@haircommander: #4554 failed to apply on top of branch "master":

Applying: Log container stop timeout
Using index info to reconstruct a base tree...
M	server/container_stop.go
Falling back to patching base and 3-way merge...
Auto-merging server/container_stop.go
CONFLICT (content): Merge conflict in server/container_stop.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Log container stop timeout
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/lgtm

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 17, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 13, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. needs-forwardport This PR should be also added to every version that comes after release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mrunalp @haircommander @openshift-cherrypick-robot @openshift-ci-robot @saschagrunert @kolyshkin @openshift-merge-robot