config/node: allow CRI-O to start if fs_may_detach_mounts is not set #4559
Conversation
unfortunately, it's possible CRI-O races with the sysctl being set, causing it to fail to start even if the sysctl is correctly set. instead, don't fatally error if it's not. Signed-off-by: Peter Hunt <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @kolyshkin I'd want your sign-off on this, we talked about it like a month ago and I forgot about it |
Codecov Report
@@ Coverage Diff @@
## master #4559 +/- ##
=======================================
Coverage 40.44% 40.44%
=======================================
Files 115 115
Lines 9360 9360
=======================================
Hits 3786 3786
Misses 5149 5149
Partials 425 425 |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The check was added in #4217. |
kolyshkin
left a comment
There was a problem hiding this comment.
Apparently (#4460 (comment)) this has uncovered a real configuration issue. This knob is very much needed on RHEL7, and so I suggest we close this PR.
What type of PR is this?
What this PR does / why we need it:
unfortunately, it's possible CRI-O races with the sysctl being set, causing it to fail to start
even if the sysctl is correctly set. instead, don't fatally error if it's not.
Signed-off-by: Peter Hunt [email protected]
Which issue(s) this PR fixes:
fixes #4558
fixes #4460
Special notes for your reviewer:
Does this PR introduce a user-facing change?