Set conmon scope KillSignal to SIGPIPE #4560
Conversation
conmon forwards the SIGTERM to the main container process. This is undesirable during node shutdown as it results in the container receving 2 SIGTERMs. With this change, conmon ignores the SIGPIPE and will exit after the main container process dies. If it doesn't for some reason, then it gets SIGKILL by systemd after 90 seconds. We need a follow-on to adjust the 90s to a value higher than the termination grace period as a follow on. This doesn't matter today as we don't retain container state on reboot. Signed-off-by: Mrunal Patel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4560 +/- ##
==========================================
+ Coverage 40.45% 40.46% +0.01%
==========================================
Files 115 115
Lines 9372 9375 +3
==========================================
+ Hits 3791 3794 +3
Misses 5156 5156
Partials 425 425 |
|
/retest |
|
LGTM |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #4546
/assign haircommander