Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.18] backports session timeout fix from 1.21 to 1.18 #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 25, 2021
Merged

[release-1.18] backports session timeout fix from 1.21 to 1.18 #4562

openshift-merge-robot merged 1 commit into from
Feb 25, 2021

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Feb 10, 2021 •
edited
Loading

What type of PR is this?

/kind api-change

/kind bug

/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

backports session timeout fix from 1.21 to 1.18
#4529

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1920300

Special notes for your reviewer:

Does this PR introduce a user-facing change?

allows session timeout to to be set as a config

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 10, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2021

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2021
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 10, 2021
@haircommander
Copy link
Member

haircommander commented Feb 10, 2021

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2021
@haircommander
Copy link
Member

haircommander commented Feb 10, 2021

can you open prs for 1.20 and 1.19 as well

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #4562 (7c920fe) into release-1.18 (0a7f692) will increase coverage by 0.00%.
The diff coverage is 41.66%.

@@              Coverage Diff              @@
##           release-1.18    #4562   +/-   ##
=============================================
  Coverage         38.70%   38.71%           
=============================================
  Files               106      106           
  Lines              7939     7951   +12     
=============================================
+ Hits               3073     3078    +5     
- Misses             4567     4574    +7     
  Partials            299      299

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 10, 2021
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Feb 10, 2021

/retest

2 similar comments
@wgahnagl
Copy link
Contributor Author

wgahnagl commented Feb 15, 2021

/retest

@relyt0925
Copy link

relyt0925 commented Feb 24, 2021

/retest

@haircommander
Copy link
Member

haircommander commented Feb 25, 2021

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@haircommander
Copy link
Member

haircommander commented Feb 25, 2021

/retest

1 similar comment
@haircommander
Copy link
Member

haircommander commented Feb 25, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 572d9f7 into cri-o:release-1.18 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@sboeuf sboeuf Awaiting requested review from sboeuf

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wgahnagl @openshift-ci-robot @haircommander @relyt0925 @openshift-merge-robot