Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Codecov Report

Merging #4564 (6c59e83) into release-1.19 (6377f68) will increase coverage by 0.00%.
The diff coverage is 41.66%.

@@              Coverage Diff              @@
##           release-1.19    #4564   +/-   ##
=============================================
  Coverage         40.87%   40.87%           
=============================================
  Files               114      114           
  Lines              8744     8756   +12     
=============================================
+ Hits               3574     3579    +5     
- Misses             4807     4814    +7     
  Partials            363      363           

/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/retest

@wgahnagl: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

/ok-to-test

LGTM
once tests are righted.

/retest

Will be helpful to provide links to original PRs/commits which are being backported in this PR description.

/retest

/lgtm

/retest

/test integration_crun

/retest integration_crun

@kolyshkin: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

• /test kata-containers
• /test ami_fedora
• /test ami_rhel
• /test critest_fedora
• /test critest_rhel
• /test e2e_crun
• /test e2e_cgroupv2
• /test e2e_features_fedora
• /test e2e_features_rhel
• /test e2e_fedora
• /test e2e_rhel
• /test integration_crun
• /test integration_cgroupv2
• /test integration_fedora
• /test integration_rhel
• /test e2e-aws
• /test images

Use /test all to run the following jobs:

• kata-containers-crio-PR
• test_pull_request_crio_critest_fedora
• test_pull_request_crio_critest_rhel
• test_pull_request_crio_e2e_crun_fedora
• test_pull_request_crio_e2e_crun_fedora_cgroupv2
• test_pull_request_crio_e2e_features_fedora
• test_pull_request_crio_e2e_features_rhel
• test_pull_request_crio_e2e_fedora
• test_pull_request_crio_e2e_rhel
• test_pull_request_crio_integration_crun_fedora
• test_pull_request_crio_integration_crun_fedora_cgroupv2
• test_pull_request_crio_integration_fedora
• test_pull_request_crio_integration_rhel
• pull-ci-cri-o-cri-o-release-1.19-e2e-aws
• pull-ci-cri-o-cri-o-release-1.19-images

/test integration_crun

Circleci build is failing because go version packaged has a bug resulting in bunch of errors like this

golang.org/x/crypto/openpgp/packet.(*Compressed).parse: relocation target compress/zlib.NewReaderDict not defined
github.com/docker/spdystream/spdy.(*Framer).uncorkHeaderDecompressor: relocation target compress/zlib.NewReaderDict not defined
github.com/docker/spdystream/spdy.NewFramer: relocation target compress/zlib.NewWriterLevelDict not defined
github.com/docker/spdystream/spdy.(*Framer).writeSynStreamFrame: relocation target compress/zlib.(*Writer).Flush not defined
github.com/docker/spdystream/spdy.(*Framer).writeSynReplyFrame: relocation target compress/zlib.(*Writer).Flush not defined
github.com/docker/spdystream/spdy.(*Framer).writeHeadersFrame: relocation target compress/zlib.(*Writer).Flush not defined

This can be fixed by using golang installed from golang.org, but I see that @haircommander is moving away from circleci to GHA (see #4604) so I think fixing circleci is useless (for now).

Still looking into integration-crun

@wgahnagl: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard.

Tried to repro integration_crun failure with more diagnostics at #4605, and it works (i.e. integration tests are passing -- there is still a problem of uploading the results back to prow, described at #4605 (comment)).

In here we have the same test failing (from https://prow.ci.openshift.org/log?job=test_pull_request_crio_integration_crun_fedora&id=1365076013226135552):

TASK [run integration tests] ***************************************************
task path: /go/src/github.com/cri-o/cri-o/contrib/test/integration/test.yml:21
fatal: [localhost]: FAILED! => {"ansible_job_id": "72200651440.24472", "changed": true, "cmd": "make localintegration >& /tmp/artifacts/testout.txt", "delta": "0:07:13.553467", "end": "2021-02-25 23:22:51.995499", "finished": 1, "msg": "non-zero return code", "rc": 2, "start": "2021-02-25 23:15:38.442032", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

but as the detailed logs (testout) is not available, I can't say anything about what was wrong.

Which returns us back to the issue described at #4605 (comment)