Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.20] backports session timeout fix from 1.21 to 1.20 #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 23, 2021
Merged

[release-1.20] backports session timeout fix from 1.21 to 1.20 #4565

openshift-merge-robot merged 1 commit into from
Feb 23, 2021

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Feb 10, 2021 •
edited
Loading

Signed-off-by: Skyler Clark [email protected]

What type of PR is this?

/kind api-change

/kind bug

/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

backports session timeout fix from 1.21 to 1.18
#4529

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1920300

Special notes for your reviewer:

Does this PR introduce a user-facing change?

allows session timeout to to be set as a config

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 10, 2021
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2021

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wgahnagl wgahnagl changed the title [release-1.19] backports session timeout fix from 1.21 to 1.18 [release-1.19] backports session timeout fix from 1.21 to 1.20 Feb 10, 2021
@wgahnagl wgahnagl changed the title [release-1.19] backports session timeout fix from 1.21 to 1.20 [release-1.20] backports session timeout fix from 1.21 to 1.20 Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #4565 (df523fc) into release-1.20 (fdbdf43) will increase coverage by 0.00%.
The diff coverage is 41.66%.

@@              Coverage Diff              @@
##           release-1.20    #4565   +/-   ##
=============================================
  Coverage         40.62%   40.62%           
=============================================
  Files               117      117           
  Lines              9449     9461   +12     
=============================================
+ Hits               3839     3844    +5     
- Misses             5177     5184    +7     
  Partials            433      433

@haircommander
Copy link
Member

haircommander commented Feb 22, 2021

/ok-to-test
/lgtm

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2021
@haircommander
Copy link
Member

haircommander commented Feb 23, 2021

/retest

@haircommander
Copy link
Member

haircommander commented Feb 23, 2021

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@haircommander
Copy link
Member

haircommander commented Feb 23, 2021

/retest

1 similar comment
@haircommander
Copy link
Member

haircommander commented Feb 23, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1f21a5a into cri-o:release-1.20 Feb 23, 2021
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 13, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wgahnagl @openshift-ci-robot @haircommander @openshift-merge-robot