Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 20, 2021

What type of PR is this?

/kind ci

What this PR does / why we need it:

Both CircleCI are now running in GitHub actions, whereas a pipeline
passes the build artifacts to those new jobs.

Which issue(s) this PR fixes:

Refers to #4489

Special notes for your reviewer:

Example run can be already found in the pipeline below.

Does this PR introduce a user-facing change?

None

Both CircleCI are now running in GitHub actions, whereas a pipeline
passes the build artifacts to those new jobs.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 20, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #4503 (a0568ac) into master (da02cd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4503   +/-   ##
=======================================
  Coverage   40.17%   40.17%           
=======================================
  Files         115      115           
  Lines        9317     9317           
=======================================
  Hits         3743     3743           
  Misses       5156     5156           
  Partials      418      418           

@saschagrunert
Copy link
Member Author

/test integration_crun

@TomSweeneyRedHat
Copy link
Contributor

LGTM
But I'm not at all a subject heavy for these kinds of changes.

@haircommander
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2021

@saschagrunert: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp a0568ac link /test e2e-gcp
ci/prow/e2e-agnostic a0568ac link /test e2e-agnostic
ci/openshift-jenkins/integration_crun_cgroupv2 a0568ac link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Jan 20, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9e20ae6 into cri-o:master Jan 20, 2021
@saschagrunert saschagrunert deleted the gh-actions branch January 21, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants