[1.20] ResourceStore: fix segfault and update tests #4535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, it was possible to segfault when a WatcherForResource was called followed by a Get as we didn't check that the resource was actually put. Fix this Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
We need to specifically register "Describe" functions, but ginkgo doesn't allow us to register multiple ones. Wrap different functionality in different Contexts so they all run. Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
mrunalp
approved these changes
Feb 2, 2021
Member
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## release-1.20 #4535 +/- ##
================================================
+ Coverage 40.54% 40.63% +0.08%
================================================
Files 117 117
Lines 9422 9436 +14
================================================
+ Hits 3820 3834 +14
+ Misses 5173 5172 -1
- Partials 429 430 +1 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
There is a chance that a WatcherForResource() followed by a Get() would cause cri-o to segfault. Fix this
also extend the test suite to add a test for this and another situation, as well as move around the tests so they're all run
Which issue(s) this PR fixes:
Special notes for your reviewer:
cherry-pick of #4530
Does this PR introduce a user-facing change?