Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup pod network on sandbox removal #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saschagrunert wants to merge 1 commit into from
Closed

Cleanup pod network on sandbox removal #4763

saschagrunert wants to merge 1 commit into from

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 15, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

We may encounter situations where sandboxes gets killed. In this case,
we now try to cleanup the network on removal of the sandbox to ensure
that no resources (like networks) left stale on the machine.

Which issue(s) this PR fixes:

Refers to #4727

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Cleanup pod networks on sandbox removal, which now removes networks even if the pod sandbox got killed.

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 15, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #4763 (f38ce27) into master (33abeef) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head f38ce27 differs from pull request most recent head 6f45877. Consider uploading reports for the commit 6f45877 to get more accurate results

@@            Coverage Diff             @@
##           master    #4763      +/-   ##
==========================================
- Coverage   43.06%   43.06%   -0.01%     
==========================================
  Files         107      107              
  Lines        9754     9756       +2     
==========================================
  Hits         4201     4201              
- Misses       5100     5102       +2     
  Partials      453      453

@saschagrunert saschagrunert force-pushed the network-sandbox-kill branch 4 times, most recently from 406aa01 to 36d4d11 Compare April 15, 2021 13:05
haircommander
haircommander reviewed Apr 15, 2021
View reviewed changes
@saschagrunert saschagrunert force-pushed the network-sandbox-kill branch 3 times, most recently from 6c65a50 to a0c92e7 Compare April 15, 2021 15:31
@saschagrunert
Cleanup pod network on sandbox removal
6f45877 
We may encounter situations where sandboxes gets killed. In this case,
we now try to cleanup the network on removal of the sandbox to ensure
that no resources (like networks) left stale on the machine.

Signed-off-by: Sascha Grunert <[email protected]>
This was referenced Apr 15, 2021
Merged
Closed
@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Apr 15, 2021

LGTM
assuming happy tests

@mrunalp
Copy link
Member

mrunalp commented Apr 19, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2021

@saschagrunert: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 6f45877 link /test e2e-gcp
ci/openshift-jenkins/e2e_crun_cgroupv2 6f45877 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 21, 2021

This is now included in #4767
/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2021

@saschagrunert: Closed this PR.

Details

In response to this:

This is now included in #4767
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert deleted the network-sandbox-kill branch April 21, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saschagrunert @TomSweeneyRedHat @mrunalp @openshift-ci-robot @openshift-bot @haircommander