Use internal logging when context available #4714

ardaguclu · 2021-04-01T13:03:13Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As stated in the issue, internal/log package stores more information than logrus and functions including context parameter should use internal/log package instead logrus.

Which issue(s) this PR fixes:

Fixes #4660

Does this PR introduce a user-facing change?

None

openshift-ci-robot · 2021-04-01T13:03:21Z

Hi @ardaguclu. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2021-04-01T14:24:12Z

Codecov Report

Merging #4714 (806f677) into master (ec8716f) will decrease coverage by 0.00%.
The diff coverage is 6.66%.

❗ Current head 806f677 differs from pull request most recent head 975ffc6. Consider uploading reports for the commit 975ffc6 to get more accurate results

@@            Coverage Diff             @@
##           master    #4714      +/-   ##
==========================================
- Coverage   41.41%   41.40%   -0.01%     
==========================================
  Files         105      105              
  Lines        9360     9361       +1     
==========================================
  Hits         3876     3876              
- Misses       5038     5039       +1     
  Partials      446      446

ardaguclu · 2021-04-01T14:57:14Z

/assign @haircommander

haircommander · 2021-04-01T15:39:33Z

/ok-to-test

thanks for taking this on @ardaguclu !

I think it may benefit you to rebase on top of #4678, as I believe there are conflicts

cmd/crio/main.go

fidencio · 2021-04-01T18:56:06Z

LGTM, but needs a rebase, which I'd say to wait for @saschagrunert's feedback (most likely next week, due to the easter break) before doing it.

TomSweeneyRedHat · 2021-04-01T21:22:14Z

LGTM
assuming happy tests and a head nod from @saschagrunert

Signed-off-by: Arda Güçlü <[email protected]>

openshift-bot · 2021-04-07T13:05:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-07T13:18:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

saschagrunert · 2021-04-07T13:26:49Z

/hold

haircommander · 2021-04-07T15:31:24Z

/retest
/hold cancel

haircommander · 2021-04-07T18:51:42Z

/override ci/openshift-jenkins/critest_fedora
/override ci/openshift-jenkins/critest_rhel

gh actions critest passed

openshift-ci-robot · 2021-04-07T18:52:01Z

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/critest_fedora, ci/openshift-jenkins/critest_rhel

Details

In response to this:

/override ci/openshift-jenkins/critest_fedora
/override ci/openshift-jenkins/critest_rhel

gh actions critest passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-07T20:14:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

haircommander · 2021-04-07T20:24:41Z

internal/log/log_test.go

+		It("should not error log", func() {
+			// Given
+			// When
+			log.Errorf(ctx, msg)


nit: I don't think this function does what we want it to

openshift-bot · 2021-04-07T20:27:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-07T20:40:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-07T21:19:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

haircommander · 2021-04-07T22:27:20Z

/override ci/openshift-jenkins/critest_rhel
/override ci/openshift-jenkins/critest_fedora

openshift-ci-robot · 2021-04-07T22:27:46Z

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/critest_fedora, ci/openshift-jenkins/critest_rhel

Details

In response to this:

/override ci/openshift-jenkins/critest_rhel
/override ci/openshift-jenkins/critest_fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-07T23:03:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-08T01:26:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-08T13:08:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

haircommander · 2021-04-08T16:26:32Z

/override ci/openshift-jenkins/critest_fedora
/override ci/openshift-jenkins/critest_rhel

openshift-ci-robot · 2021-04-08T16:45:22Z

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/critest_fedora, ci/openshift-jenkins/critest_rhel

Details

In response to this:

/override ci/openshift-jenkins/critest_fedora
/override ci/openshift-jenkins/critest_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-08T17:02:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

haircommander · 2021-04-08T20:00:17Z

/override ci/prow/e2e-gcp
(got e2e-agnositc)

openshift-ci-robot · 2021-04-08T20:00:25Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-gcp
(got e2e-agnositc)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-08T21:22:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-08T22:40:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-09T00:24:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-04-09T01:04:17Z

@ardaguclu: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2	`975ffc6`	link	`/test e2e_cgroupv2`
ci/openshift-jenkins/integration_crun_cgroupv2	`975ffc6`	link	`/test integration_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-04-09T01:16:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ardaguclu requested review from mrunalp and runcom as code owners April 1, 2021 13:03

openshift-ci-robot requested review from nalind and vrothberg April 1, 2021 13:03

ardaguclu force-pushed the use-internal-logging branch 2 times, most recently from 72710f8 to 9a6b82e Compare April 1, 2021 13:52

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 1, 2021

ardaguclu force-pushed the use-internal-logging branch from 9a6b82e to 40e1de4 Compare April 1, 2021 14:20

openshift-ci-robot assigned haircommander Apr 1, 2021

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2021

haircommander reviewed Apr 1, 2021

View reviewed changes

cmd/crio/main.go Show resolved Hide resolved

ardaguclu force-pushed the use-internal-logging branch from 40e1de4 to abfca3f Compare April 2, 2021 06:30

openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 2, 2021

Use internal logging when context available

975ffc6

Signed-off-by: Arda Güçlü <[email protected]>

ardaguclu force-pushed the use-internal-logging branch from abfca3f to 975ffc6 Compare April 2, 2021 06:31

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021

haircommander added this to the 1.21 milestone Apr 7, 2021

haircommander reviewed Apr 7, 2021

View reviewed changes

openshift-merge-robot merged commit 8118d4a into cri-o:master Apr 9, 2021

Use internal logging when context available #4714

Use internal logging when context available #4714

Uh oh!

Conversation

ardaguclu commented Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Apr 1, 2021

Uh oh!

codecov bot commented Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ardaguclu commented Apr 1, 2021

Uh oh!

haircommander commented Apr 1, 2021

Uh oh!

Uh oh!

fidencio commented Apr 1, 2021

Uh oh!

TomSweeneyRedHat commented Apr 1, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

saschagrunert commented Apr 7, 2021

Uh oh!

haircommander commented Apr 7, 2021

Uh oh!

haircommander commented Apr 7, 2021

Uh oh!

openshift-ci-robot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

haircommander Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

haircommander commented Apr 7, 2021

Uh oh!

openshift-ci-robot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 7, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

haircommander commented Apr 8, 2021

Uh oh!

openshift-ci-robot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

haircommander commented Apr 8, 2021

Uh oh!

openshift-ci-robot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 9, 2021

Uh oh!

openshift-ci bot commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 9, 2021

Uh oh!

ardaguclu commented Apr 1, 2021 •

edited

Loading

codecov bot commented Apr 1, 2021 •

edited

Loading

openshift-ci bot commented Apr 9, 2021 •

edited

Loading