Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bump(deps): protobuf, grpc for open-telemetry #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sallyom wants to merge 1 commit into from
Closed

bump(deps): protobuf, grpc for open-telemetry #4843

sallyom wants to merge 1 commit into from

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented May 4, 2021

Signed-off-by: Sally O'Malley [email protected]

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

protobuf and grpc update
running through CI to detect issues

Does this PR introduce a user-facing change?

NONE

@sallyom sallyom requested review from mrunalp and runcom as code owners May 4, 2021 17:05
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels May 4, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2021

Hi @sallyom. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sallyom
To complete the pull request process, please assign rhatdan after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhatdan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member

haircommander commented May 4, 2021

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021 •
edited
Loading

Codecov Report

Merging #4843 (8dfbaed) into master (7a7df87) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 8dfbaed differs from pull request most recent head cd8ba7a. Consider uploading reports for the commit cd8ba7a to get more accurate results

@@            Coverage Diff             @@
##           master    #4843      +/-   ##
==========================================
+ Coverage   42.98%   43.00%   +0.02%     
==========================================
  Files         107      107              
  Lines        9809     9792      -17     
==========================================
- Hits         4216     4211       -5     
+ Misses       5142     5130      -12     
  Partials      451      451

saschagrunert
saschagrunert reviewed May 5, 2021
View reviewed changes
go.mod
// is included in the runc release
github.com/syndtr/gocapability => github.com/syndtr/gocapability v0.0.0-20180916011248-d98352740cb2
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20200117163144-32f20d992d24
google.golang.org/grpc => google.golang.org/grpc v1.27.0
Copy link
Member

@saschagrunert saschagrunert May 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a kata containers related reason to pin the dependency here (#4164). Is this obsolete now?

/cc @fidencio

If so, then I would recommend removing the lines completely to automatically vendor
google.golang.org/grpc v1.37.0.

Copy link
Contributor Author

@sallyom sallyom May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask around, I dunno if this is still necessary.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sallyom
To complete the pull request process, please assign rhatdan after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhatdan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@sallyom: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun cd8ba7a link /test integration_crun
ci/openshift-jenkins/e2e_crun cd8ba7a link /test e2e_crun
ci/prow/e2e-gcp cd8ba7a link /test e2e-gcp
ci/prow/e2e-agnostic cd8ba7a link /test e2e-agnostic
ci/openshift-jenkins/e2e_crun_cgroupv2 cd8ba7a link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sallyom
Copy link
Contributor Author

sallyom commented May 11, 2021

I'll close this as I've included the bump in the tracing PR: #4883. I've moved the comment about whether kata needs protobuf pinned there, also.

@sallyom sallyom closed this May 11, 2021
@sallyom sallyom mentioned this pull request May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sallyom @openshift-ci-robot @haircommander @saschagrunert