reduce listen socket permissions to 0660 #4886
Conversation
|
LGTM, thanks @haircommander! If there's a bug report about this, please, link to the bug in the commit message. |
cgwalters
left a comment
There was a problem hiding this comment.
Personally I'd go for 0600 to be extra clear. But fine as is!
It clearly makes sense to merge this as is, but one high level note here - systemd .socket units can already set permission mode, and systemd handles permissions atomically. There's a lot of benefits of going to socket activation.
saschagrunert
left a comment
There was a problem hiding this comment.
Just a nit, otherwise LGTM
cmd/crio/main.go
Outdated
| } | ||
|
|
||
| if err := os.Chmod(config.Listen, 0o660); err != nil { | ||
| logrus.Fatalf("failed to chmod listen socket %s: %v", config.Listen, err) |
There was a problem hiding this comment.
| logrus.Fatalf("failed to chmod listen socket %s: %v", config.Listen, err) | |
| logrus.Fatalf("Failed to chmod listen socket %s: %v", config.Listen, err) |
There was a problem hiding this comment.
fixed that and another case
|
LGTM |
Signed-off-by: Peter Hunt <[email protected]>
|
oops I had titled this wrong my intuition is that 660 is good for now, so that users can run crictl in the root group but not as root |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, giuseppe, haircommander, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-1.21 |
|
@haircommander: new pull request created: #4930 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
because, why not?
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?