Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.21] Fix go.sum #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 11, 2021
Merged

[1.21] Fix go.sum #4889

openshift-merge-robot merged 1 commit into from
May 11, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 11, 2021

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The vendor CI step is failing on this branch, which should be fixed by
running go mod tidy.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@saschagrunert
Fix go.sum
0f1297a 
The vendor CI step is failing on this branch, which should be fixed by
running `go mod tidy`.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels May 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from rhatdan and umohnani8 May 11, 2021 07:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@saschagrunert saschagrunert changed the title Fix go.sum [1.21] Fix go.sum May 11, 2021
@cri-o cri-o deleted a comment from openshift-ci bot May 11, 2021
@saschagrunert
Copy link
Member Author

saschagrunert commented May 11, 2021

/test e2e-aws

@fidencio
Copy link
Contributor

fidencio commented May 11, 2021 •
edited
Loading

From test / bundle-test (pull_request)

+ crictl run /home/runner/work/cri-o/cri-o/test/testdata/container_redis.json /home/runner/work/cri-o/cri-o/test/testdata/sandbox_config.json
time="2021-05-11T07:24:32Z" level=fatal msg="running container: creating container failed: rpc error: code = Unknown desc = container create failed: invalid value for `After`\n"
make: *** [Makefile:393: bundle-test] Error 1

Not related, but worth to take a look.

@fidencio
Copy link
Contributor

fidencio commented May 11, 2021

LGTM, thanks @saschagrunert!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021

@saschagrunert: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 0f1297a link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented May 11, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit b186f24 into cri-o:release-1.21 May 11, 2021
@saschagrunert saschagrunert deleted the release-1.21-go-sum branch May 12, 2021 06:46
@openshift-ci openshift-ci bot mentioned this pull request Jun 8, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschagrunert @fidencio @haircommander @openshift-merge-robot