Use extra context for runtime VM #4803
Conversation
We now partially revert cri-o#4650 to still use the runtime internal context for its tasks. Fixes: cri-o#4798 Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saschagrunert, thanks for the PR, it does solve the issue I reported. tl;dr: LGTM, we should proceed with this PR, and I'd like to hear from @haircommander before adding my Now, the long reply ... It bogus my mind, sincerely, and I've gone through this on Friday, coming up with pretty much the same solution proposed by in this PR, then I filed the issue. I still don't fully get why we need the extra context, why the context coming from the GRPC doesn't do what it has to do. @saschagrunert mentioned this may be a bug in the GRPC implementation of the runtime VM, and he may very much be right about that. For now, I'm looking forward to have this partial revert merged, and backported to the |
Codecov Report
@@ Coverage Diff @@
## master #4803 +/- ##
==========================================
- Coverage 43.00% 43.00% -0.01%
==========================================
Files 107 107
Lines 9791 9792 +1
==========================================
Hits 4211 4211
- Misses 5130 5131 +1
Partials 450 450 |
|
/retest |
|
/lgtm |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
thanks for tracking this down y'all |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@haircommander: new pull request created: #4812 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cri-o#4803 partially reverted cri-o#4650, but ended up missing two places where the context is used to ensure the goroutines are stopped. This was caught due to some tests failing in a non deterministic manner on kata-containers CI. Related: cri-o#4798
cri-o#4803 partially reverted cri-o#4650, but ended up missing two places where the context is used to ensure the goroutines are stopped. This was caught due to some tests failing in a non deterministic manner on kata-containers CI. Related: cri-o#4798 Signed-off-by: Fabiano Fidêncio <[email protected]>
cri-o#4803 partially reverted cri-o#4650, but ended up missing two places where the context is used to ensure the goroutines are stopped. This was caught due to some tests failing in a non deterministic manner on kata-containers CI. Related: - cri-o#4798 - kata-containers/tests#3503 (comment) Signed-off-by: Fabiano Fidêncio <[email protected]>
cri-o#4803 partially reverted cri-o#4650, but ended up missing two places where the context is used to ensure the goroutines are stopped. This was caught due to some tests failing in a non deterministic manner on kata-containers CI. Related: - cri-o#4798 - kata-containers/tests#3503 (comment) Signed-off-by: Fabiano Fidêncio <[email protected]> (cherry picked from commit db280b4)
What type of PR is this?
/kind bug
What this PR does / why we need it:
We now partially revert #4650 to
still use the runtime internal context for its tasks.
Which issue(s) this PR fixes:
Fixes: #4798
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?