main: still rely on logrus (rather than using the internal log) #4804

fidencio · 2021-04-26T09:11:13Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

This is a partial revert of 975ffc6,
where we started using the internal log when the context is avaiable.

It turns out that we missed a few pieces during the review, where we end
up using the internal log without having the interceptors set up. This
was raised by @haircommander during the review, we checked a few parts
of the patch, but we still missed a few others.

We can only use the internal logging after

cri-o/cmd/crio/main.go

Line 222 in d3dbaec

grpc.StreamInterceptor(log.StreamInterceptor()),

happens. From this moment, we start having different ways of logging in
the very same file and consistency becomes a problem then.

With the consistency in mind, I'd like to only use logrus for
debugging as part of this file.

Note: This was noticed when debugging
#4798

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

I think this one should also be backported to the release-1.21 branch,

Does this PR introduce a user-facing change?

None

@haircommander

This is a partial revert of 975ffc6, where we started using the internal log when the context is avaiable. It turns out that we missed a few pieces during the review, where we end up using the internal log without having the interceptors set up. This was raised by @haircommander during the review, we checked a few parts of the patch, but we still missed a few others. We can only use the internal logging after https://github.com/cri-o/cri-o/blob/d3dbaec060e33870e5cb5c3f7ec4207837804b00/cmd/crio/main.go#L222 happens. From this moment, we start having different ways of logging in the very same file and consistency becomes a problem then. With the consistency in mind, I'd like to **only** use logrus for debugging as part of this file. Note: This was noticed when debugging cri-o#4798 Signed-off-by: Fabiano Fidêncio <[email protected]>

openshift-ci-robot · 2021-04-26T09:11:15Z

@fidencio: The label(s) kind/bugr cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind bugr

What this PR does / why we need it:

This is a partial revert of 975ffc6,
where we started using the internal log when the context is avaiable.

It turns out that we missed a few pieces during the review, where we end
up using the internal log without having the interceptors set up. This
was raised by @haircommander during the review, we checked a few parts
of the patch, but we still missed a few others.

We can only use the internal logging after

cri-o/cmd/crio/main.go

Line 222 in d3dbaec

grpc.StreamInterceptor(log.StreamInterceptor()),

happens. From this moment, we start having different ways of logging in
the very same file and consistency becomes a problem then.

With the consistency in mind, I'd like to only use logrus for
debugging as part of this file.

Note: This was noticed when debugging
#4798

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

I think this one should also be backported to the release-1.21 branch,

Does this PR introduce a user-facing change?
None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fidencio · 2021-04-26T09:11:47Z

/cc @saschagrunert

codecov · 2021-04-26T09:13:52Z

Codecov Report

Merging #4804 (39c356c) into master (d3dbaec) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 39c356c differs from pull request most recent head 33f2996. Consider uploading reports for the commit 33f2996 to get more accurate results

@@            Coverage Diff             @@
##           master    #4804      +/-   ##
==========================================
+ Coverage   43.00%   43.02%   +0.02%     
==========================================
  Files         107      107              
  Lines        9791     9791              
==========================================
+ Hits         4211     4213       +2     
+ Misses       5130     5128       -2     
  Partials      450      450

fidencio · 2021-04-26T09:43:59Z

/retest

saschagrunert

LGTM

haircommander · 2021-04-26T13:46:54Z

/lgtm
/cherry-pick release-1.21

openshift-cherrypick-robot · 2021-04-26T13:46:54Z

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-26T14:15:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-26T14:28:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-26T14:40:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-26T15:45:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

fidencio · 2021-04-26T17:30:49Z

/retest

openshift-ci-robot · 2021-04-26T18:55:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fidencio, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [fidencio,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrunalp · 2021-04-26T18:55:18Z

/lgtm

openshift-bot · 2021-04-26T19:43:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-26T20:04:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-26T20:17:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-04-26T20:18:47Z

@fidencio: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2	`33f2996`	link	`/test e2e_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-04-26T21:22:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-cherrypick-robot · 2021-04-26T23:15:45Z

@haircommander: new pull request created: #4810

Details

In response to this:

/lgtm
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fidencio requested review from mrunalp and runcom as code owners April 26, 2021 09:11

openshift-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 26, 2021

openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 26, 2021

openshift-ci-robot requested review from sameo and sboeuf April 26, 2021 09:11

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021

openshift-ci-robot requested a review from saschagrunert April 26, 2021 09:11

saschagrunert approved these changes Apr 26, 2021

View reviewed changes

openshift-ci-robot assigned haircommander Apr 26, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2021

mrunalp approved these changes Apr 26, 2021

View reviewed changes

openshift-ci-robot assigned mrunalp Apr 26, 2021

openshift-merge-robot merged commit e33ccae into cri-o:master Apr 26, 2021

openshift-cherrypick-robot mentioned this pull request Apr 26, 2021

[release-1.21] main: still rely on logrus (rather than using the internal log) #4810

Merged

main: still rely on logrus (rather than using the internal log) #4804

main: still rely on logrus (rather than using the internal log) #4804

Uh oh!

Conversation

fidencio commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Apr 26, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

fidencio commented Apr 26, 2021

Uh oh!

codecov bot commented Apr 26, 2021

Codecov Report

Uh oh!

fidencio commented Apr 26, 2021

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

haircommander commented Apr 26, 2021

Uh oh!

openshift-cherrypick-robot commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

fidencio commented Apr 26, 2021

Uh oh!

openshift-ci-robot commented Apr 26, 2021

Uh oh!

mrunalp commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-ci bot commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-cherrypick-robot commented Apr 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fidencio commented Apr 26, 2021 •

edited

Loading

openshift-ci bot commented Apr 26, 2021 •

edited

Loading