Thanks to visit codestin.com
Credit goes to github.com

Skip to content

config: fix type of privileged_without_host_devices #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 30, 2021
Merged

config: fix type of privileged_without_host_devices #4827

openshift-merge-robot merged 1 commit into from
Apr 30, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Apr 29, 2021

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

it is a bool, not a string

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a bug where `crio config` would print a string for `privileged_without_host_devices`, not a boolean

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 29, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@haircommander
Copy link
Member Author

haircommander commented Apr 29, 2021

/cherry-pick release-1.21

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 29, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fidencio
Copy link
Contributor

fidencio commented Apr 29, 2021

LGTM, thanks @haircommander!

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #4827 (fd0a878) into master (ce8057c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
+ Coverage   43.00%   43.02%   +0.02%     
==========================================
  Files         107      107              
  Lines        9792     9792              
==========================================
+ Hits         4211     4213       +2     
+ Misses       5131     5129       -2     
  Partials      450      450

mrunalp
mrunalp approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 30, 2021 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 fd0a878 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fidencio
Copy link
Contributor

fidencio commented Apr 30, 2021

/test e2e-gcp

@openshift-merge-robot openshift-merge-robot merged commit 7b9dbd7 into cri-o:master Apr 30, 2021
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 30, 2021

@haircommander: new pull request created: #4829

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@sameo sameo Awaiting requested review from sameo

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@haircommander @openshift-cherrypick-robot @fidencio @openshift-ci-robot @mrunalp @openshift-merge-robot