[1.19] oci: do not use conmon for exec sync #4953
Conversation
It is not really needed, and causes unnecessary overhead. Plus, we drop an unkillable child from the mix allowing cri-o to keep track of its children better. Signed-off-by: Peter Hunt <[email protected]> Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mrunalp @haircommander PTAL |
|
/test images |
|
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
It is not really needed, and causes unnecessary overhead. Plus, we drop an unkillable child from the mix
allowing cri-o to keep track of its children better.
Which issue(s) this PR fixes:
Backport of #4943
Special notes for your reviewer:
eebef46 is not part of this backport, because we do not have internal types at this point in time.
Does this PR introduce a user-facing change?