[1.20] oci: do not use conmon for exec sync #4954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not really needed, and causes unnecessary overhead. Plus, we drop an unkillable child from the mix allowing cri-o to keep track of its children better. Signed-off-by: Peter Hunt <[email protected]> Signed-off-by: Sascha Grunert <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b19b018 to
4a60ec3
Compare
Signed-off-by: Peter Hunt <[email protected]> Signed-off-by: Sascha Grunert <[email protected]>
4a60ec3 to
046d81f
Compare
Signed-off-by: Sascha Grunert <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.20 #4954 +/- ##
================================================
+ Coverage 40.62% 41.22% +0.59%
================================================
Files 117 117
Lines 9449 9487 +38
================================================
+ Hits 3839 3911 +72
+ Misses 5177 5124 -53
- Partials 433 452 +19 |
Member
Author
|
@mrunalp @haircommander PTAL |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It is not really needed, and causes unnecessary overhead. Plus, we drop an unkillable child from the mix
allowing cri-o to keep track of its children better.
Which issue(s) this PR fixes:
Backport of #4943
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?